Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flaky tests: async after open #24

Closed
lukekarrys opened this issue Jan 25, 2023 · 0 comments · Fixed by #25
Closed

flaky tests: async after open #24

lukekarrys opened this issue Jan 25, 2023 · 0 comments · Fixed by #25

Comments

@lukekarrys
Copy link
Contributor

lukekarrys commented Jan 25, 2023

The write tests that wait for open before writing to the stream sometimes have missing data from the file after the finish event:

These two tests have been flaky across node versions and platforms:

https://github.com/npm/fs-minipass/blob/54a6a0d2bb5e4f8a4949180ab14e2ded5a9c20d2/test/write.js#L103

https://github.com/npm/fs-minipass/blob/54a6a0d2bb5e4f8a4949180ab14e2ded5a9c20d2/test/write.js#L121

After initial triage with @nlf, we think the culprit might be the _flush method being called more than once synchronously without the fs.writev callback finishing.

https://github.com/npm/fs-minipass/blob/54a6a0d2bb5e4f8a4949180ab14e2ded5a9c20d2/lib/index.js#L372-L373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant