Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle range lock sector #269

Closed
jeremy-visionaid opened this issue Dec 5, 2024 · 3 comments · Fixed by #270
Closed

Handle range lock sector #269

jeremy-visionaid opened this issue Dec 5, 2024 · 3 comments · Fixed by #270
Assignees
Labels

Comments

@jeremy-visionaid
Copy link
Collaborator

jeremy-visionaid commented Dec 5, 2024

V4 is supposed to have a range lock sector at 0x7FFFFF00-0x7FFFFFFF to support transactions/concurrency, but there is little detail in MS-CFB on how to handle it:

https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-cfb/947df128-1f4a-4c02-b6ed-6d1d0c04c02f

@jeremy-visionaid
Copy link
Collaborator Author

@ironfede I need to fix up writing ENDOFCHAIN/FREESECT as appropriate in the draft still, but it looks to me like DoCheckSizeLimitReached is incorrect in v2.4 since it compares 0x7FFFFF00 to the sector count (not the stream/file offset)? Not sure if you want to do anything about that...?

@ironfede
Copy link
Owner

ironfede commented Dec 5, 2024

@jeremy-visionaid thank you for the point but I have not fully understand what you ask me. Do you want me to fix in 2.4 branch this possible issue? Or do you prefer to chek this issue directly also in 2.4? I will take a look but I'm honestly too much busy at the moment. I will surely take in account your report since I think you're absolutely right in pointing at it in 2.4 but I have to postpone it. Thank you for all of your work!

@jeremy-visionaid
Copy link
Collaborator Author

@ironfede Yeah, I'll handle the 3.0 range lock sector if you can fix it for 2.4 if/when you find the time (since you're more familiar with it than me). It's summer over here, so I'm looking to take some much needed time off soon! I'd fix it for 2.4 if I had the time, but just letting you know about it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants