Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All disks might be detached from Machine #1229

Closed
lukas016 opened this issue Feb 5, 2025 · 1 comment · Fixed by #1230
Closed

All disks might be detached from Machine #1229

lukas016 opened this issue Feb 5, 2025 · 1 comment · Fixed by #1230
Assignees
Labels
bug Something isn't working

Comments

@lukas016
Copy link
Contributor

lukas016 commented Feb 5, 2025

Describe the bug
We are using ceph disks only.
Sometimes all disks from vm (+ disk with os) are detach from vm.
Problem is in our region cluster (user api cluster -> region cluster -> compute cluster). Where machinepoollet delete all disks on region cluster and it is propagated into compute cluster.

2025-01-31T14:23:06Z    DEBUG   Updating volumes        {"controller": "machine", "controllerGroup": "compute.ironcore.dev", "controllerKind": "Machine", "Machine": {"name":"crs9-worker-lab1-674f5-58v9l","namespace":"crs9"}, "namespace": "crs9", "name": "crs9-worker-lab1-674f5-58v9l", "reconcileID": "222fd02e-944e-4055-8c7d-3604a4d432b0"}
2025-01-31T14:23:06Z    DEBUG   volumes: [{{Volume storage.ironcore.dev/v1alpha1} {csi-ironcore-013a9aeaf9  crs9  de4ca735-6f3f-46ed-91fb-e1a5e6e73c43 499451759 0 2025-01-29 12:30:11 +0000 UTC <nil> <nil> map[] map[] [] [volumepoollet.ironcore.dev/volume] [{csi.ironcore.dev/volume Apply storage.ironcore.dev/v1alpha1 2025-01-29 12:30:11 +0000 UTC FieldsV1 {"f:spec":{"f:resources":{"f:storage":{}},"f:volumeClassRef":{},"f:volumePoolRef":{}},"f:status":{}} } {volumepoollet Update storage.ironcore.dev/v1alpha1 2025-01-29 12:30:31 +0000 UTC FieldsV1 {"f:metadata":{"f:finalizers":{".":{},"v:\"volumepoollet.ironcore.dev/volume\"":{}}}} } {volumepoollet Update storage.ironcore.dev/v1alpha1 2025-01-29 12:30:33 +0000 UTC FieldsV1 {"f:status":{"f:access":{".":{},"f:driver":{},"f:handle":{},"f:secretRef":{},"f:volumeAttributes":{".":{},"f:image":{},"f:monitors":{}}},"f:lastStateTransitionTime":{},"f:state":{}}} status} {machinepoollet Update storage.ironcore.dev/v1alpha1 2025-01-30 16:21:55 +0000 UTC FieldsV1 {"f:spec":{"f:claimRef":{}}} }]} {&LocalObjectReference{Name:fast,} map[] &LocalObjectReference{Name:lab,} 0xc002d8efa0 map[storage:{{10737418240 0} {<nil>} 10Gi BinarySI}]  nil false [] <nil>} {Available 2025-01-29 12:30:33 +0000 UTC 0xc0022fe450 []}} {{Volume storage.ironcore.dev/v1alpha1} {crs9-worker-lab1-674f5-58v9l-primary  crs9  91db4327-e6dd-48b8-be69-5a4cecc11380 499334053 0 2025-01-30 14:06:32 +0000 UTC <nil> <nil> map[] map[common.ironcore.dev/ephemeral-managed-by:ephemeral-manager] [{compute.ironcore.dev/v1alpha1 Machine crs9-worker-lab1-674f5-58v9l d66a0c68-1d5e-4001-bc35-242cb0554229 0xc002c7c45c 0xc002c7c45d}] [volumepoollet.ironcore.dev/volume] [{ironcore-controller-manager Update storage.ironcore.dev/v1alpha1 2025-01-30 14:06:32 +0000 UTC FieldsV1 {"f:metadata":{"f:annotations":{".":{},"f:common.ironcore.dev/ephemeral-managed-by":{}},"f:ownerReferences":{".":{},"k:{\"uid\":\"d66a0c68-1d5e-4001-bc35-242cb0554229\"}":{}}},"f:spec":{"f:image":{},"f:resources":{".":{},"f:storage":{}},"f:volumeClassRef":{},"f:volumePoolRef":{}}} } {volumepoollet Update storage.ironcore.dev/v1alpha1 2025-01-30 14:06:33 +0000 UTC FieldsV1 {"f:metadata":{"f:finalizers":{".":{},"v:\"volumepoollet.ironcore.dev/volume\"":{}}}} } {volumepoollet Update storage.ironcore.dev/v1alpha1 2025-01-30 14:06:33 +0000 UTC FieldsV1 {"f:status":{"f:access":{".":{},"f:driver":{},"f:handle":{},"f:secretRef":{},"f:volumeAttributes":{".":{},"f:image":{},"f:monitors":{}}},"f:lastStateTransitionTime":{},"f:state":{}}} status} {machinepoollet Update storage.ironcore.dev/v1alpha1 2025-01-30 14:08:04 +0000 UTC FieldsV1 {"f:spec":{"f:claimRef":{}}} }]} {&LocalObjectReference{Name:fast,} map[] &LocalObjectReference{Name:lab1,} 0xc002d8f000 map[storage:{{53687091200 0} {<nil>} 50Gi BinarySI}] ghcr.io/t-systems/gardenlinux:kvm-cilium-k3s-1461.0-e82c34ca nil false [] <nil>} {Available 2025-01-30 14:06:33 +0000 UTC 0xc0022fe6c0 []}} {{Volume storage.ironcore.dev/v1alpha1} {csi-ironcore-1d01be69ef  crs9  b1dfe290-c5d6-4c9b-8a1b-abfcfb09982b 500525410 0 2025-01-29 12:30:07 +0000 UTC <nil> <nil> map[] map[] [] [volumepoollet.ironcore.dev/volume] [{csi.ironcore.dev/volume Apply storage.ironcore.dev/v1alpha1 2025-01-29 12:30:07 +0000 UTC FieldsV1 {"f:spec":{"f:resources":{"f:storage":{}},"f:volumeClassRef":{},"f:volumePoolRef":{}},"f:status":{}} } {volumepoollet Update storage.ironcore.dev/v1alpha1 2025-01-29 12:30:22 +0000 UTC FieldsV1 {"f:metadata":{"f:finalizers":{".":{},"v:\"volumepoollet.ironcore.dev/volume\"":{}}}} } {volumepoollet Update storage.ironcore.dev/v1alpha1 2025-01-29 12:30:26 +0000 UTC FieldsV1 {"f:status":{"f:access":{".":{},"f:driver":{},"f:handle":{},"f:secretRef":{},"f:volumeAttributes":{".":{},"f:image":{},"f:monitors":{}}},"f:lastStateTransitionTime":{},"f:state":{}}} status} {machinepoollet Update storage.ironcore.dev/v1alpha1 2025-01-31 14:17:19 +0000 UTC FieldsV1 {"f:spec":{"f:claimRef":{}}} }]} {&LocalObjectReference{Name:fast,} map[] &LocalObjectReference{Name:lab,} 0xc002d8f180 map[storage:{{10737418240 0} {<nil>} 10Gi BinarySI}]  nil false [] <nil>} {Available 2025-01-29 12:30:26 +0000 UTC 0xc0022feb70 []}} {{Volume storage.ironcore.dev/v1alpha1} {csi-ironcore-111345950a  crs9  e35c9415-01e7-4c3a-bcf3-84373c1af3be 499453406 0 2025-01-29 12:30:11 +0000 UTC <nil> <nil> map[] map[] [] [volumepoollet.ironcore.dev/volume] [{csi.ironcore.dev/volume Apply storage.ironcore.dev/v1alpha1 2025-01-29 12:30:11 +0000 UTC FieldsV1 {"f:spec":{"f:resources":{"f:storage":{}},"f:volumeClassRef":{},"f:volumePoolRef":{}},"f:status":{}} } {volumepoollet Update storage.ironcore.dev/v1alpha1 2025-01-29 12:30:31 +0000 UTC FieldsV1 {"f:metadata":{"f:finalizers":{".":{},"v:\"volumepoollet.ironcore.dev/volume\"":{}}}} } {volumepoollet Update storage.ironcore.dev/v1alpha1 2025-01-29 12:30:34 +0000 UTC FieldsV1 {"f:status":{"f:access":{".":{},"f:driver":{},"f:handle":{},"f:secretRef":{},"f:volumeAttributes":{".":{},"f:image":{},"f:monitors":{}}},"f:lastStateTransitionTime":{},"f:state":{}}} status} {machinepoollet Update storage.ironcore.dev/v1alpha1 2025-01-30 16:23:34 +0000 UTC FieldsV1 {"f:spec":{"f:claimRef":{}}} }]} {&LocalObjectReference{Name:fast,} map[] &LocalObjectReference{Name:lab,} 0xc002d8f1a0 map[storage:{{10737418240 0} {<nil>} 10Gi BinarySI}]  nil false [] <nil>} {Available 2025-01-29 12:30:33 +0000 UTC 0xc0022fec00 []}} {{Volume storage.ironcore.dev/v1alpha1} {csi-ironcore-018c0e70e9  crs9  4e98fa6b-d5c2-4c8e-a62c-b745133e7d14 500525411 0 2025-01-29 12:30:10 +0000 UTC <nil> <nil> map[] map[] [] [volumepoollet.ironcore.dev/volume] [{csi.ironcore.dev/volume Apply storage.ironcore.dev/v1alpha1 2025-01-29 12:30:10 +0000 UTC FieldsV1 {"f:spec":{"f:resources":{"f:storage":{}},"f:volumeClassRef":{},"f:volumePoolRef":{}},"f:status":{}} } {volumepoollet Update storage.ironcore.dev/v1alpha1 2025-01-29 12:30:28 +0000 UTC FieldsV1 {"f:metadata":{"f:finalizers":{".":{},"v:\"volumepoollet.ironcore.dev/volume\"":{}}}} } {volumepoollet Update storage.ironcore.dev/v1alpha1 2025-01-29 12:30:30 +0000 UTC FieldsV1 {"f:status":{"f:access":{".":{},"f:driver":{},"f:handle":{},"f:secretRef":{},"f:volumeAttributes":{".":{},"f:image":{},"f:monitors":{}}},"f:lastStateTransitionTime":{},"f:state":{}}} status} {machinepoollet Update storage.ironcore.dev/v1alpha1 2025-01-31 14:17:19 +0000 UTC FieldsV1 {"f:spec":{"f:claimRef":{}}} }]} {&LocalObjectReference{Name:fast,} map[] &LocalObjectReference{Name:lab,} 0xc002d8f1e0 map[storage:{{10737418240 0} {<nil>} 10Gi BinarySI}]  nil false [] <nil>} {Available 2025-01-29 12:30:30 +0000 UTC 0xc0022fedb0 []}} {{Volume storage.ironcore.dev/v1alpha1} {csi-ironcore-30c3b9a9cd  crs9  2000ce60-8fb2-4aca-90cf-75bcf413af2e 500525412 0 2025-01-29 12:30:08 +0000 UTC <nil> <nil> map[] map[] [] [volumepoollet.ironcore.dev/volume] [{csi.ironcore.dev/volume Apply storage.ironcore.dev/v1alpha1 2025-01-29 12:30:08 +0000 UTC FieldsV1 {"f:spec":{"f:resources":{"f:storage":{}},"f:volumeClassRef":{},"f:volumePoolRef":{}},"f:status":{}} } {volumepoollet Update storage.ironcore.dev/v1alpha1 2025-01-29 12:30:18 +0000 UTC FieldsV1 {"f:metadata":{"f:finalizers":{".":{},"v:\"volumepoollet.ironcore.dev/volume\"":{}}}} } {volumepoollet Update storage.ironcore.dev/v1alpha1 2025-01-29 12:30:24 +0000 UTC FieldsV1 {"f:status":{"f:access":{".":{},"f:driver":{},"f:handle":{},"f:secretRef":{},"f:volumeAttributes":{".":{},"f:image":{},"f:monitors":{}}},"f:lastStateTransitionTime":{},"f:state":{}}} status} {machinepoollet Update storage.ironcore.dev/v1alpha1 2025-01-31 14:17:19 +0000 UTC FieldsV1 {"f:spec":{"f:claimRef":{}}} }]} {&LocalObjectReference{Name:fast,} map[] &LocalObjectReference{Name:lab,} 0xc002d8f200 map[storage:{{10737418240 0} {<nil>} 10Gi BinarySI}]  nil false [] <nil>} {Available 2025-01-29 12:30:24 +0000 UTC 0xc0022fee40 []}} {{Volume storage.ironcore.dev/v1alpha1} {csi-ironcore-bfc65e91cd  crs9  4b98011d-b7fd-4998-8ae3-1c0856e18acc 500525413 0 2025-01-29 12:30:08 +0000 UTC <nil> <nil> map[] map[] [] [volumepoollet.ironcore.dev/volume] [{csi.ironcore.dev/volume Apply storage.ironcore.dev/v1alpha1 2025-01-29 12:30:08 +0000 UTC FieldsV1 {"f:spec":{"f:resources":{"f:storage":{}},"f:volumeClassRef":{},"f:volumePoolRef":{}},"f:status":{}} } {volumepoollet Update storage.ironcore.dev/v1alpha1 2025-01-29 12:30:27 +0000 UTC FieldsV1 {"f:metadata":{"f:finalizers":{".":{},"v:\"volumepoollet.ironcore.dev/volume\"":{}}}} } {volumepoollet Update storage.ironcore.dev/v1alpha1 2025-01-29 12:30:29 +0000 UTC FieldsV1 {"f:status":{"f:access":{".":{},"f:driver":{},"f:handle":{},"f:secretRef":{},"f:volumeAttributes":{".":{},"f:image":{},"f:monitors":{}}},"f:lastStateTransitionTime":{},"f:state":{}}} status} {machinepoollet Update storage.ironcore.dev/v1alpha1 2025-01-31 14:17:19 +0000 UTC FieldsV1 {"f:spec":{"f:claimRef":{}}} }]} {&LocalObjectReference{Name:fast,} map[] &LocalObjectReference{Name:lab,} 0xc002d8f220 map[storage:{{10737418240 0} {<nil>} 10Gi BinarySI}]  nil false [] <nil>} {Available 2025-01-29 12:30:29 +0000 UTC 0xc0022feed0 []}} {{Volume storage.ironcore.dev/v1alpha1} {csi-ironcore-aedbef721c  crs9  1b3f493c-774a-4c87-9c5b-6b05d348e7b5 499451757 0 2025-01-29 12:30:11 +0000 UTC <nil> <nil> map[] map[] [] [volumepoollet.ironcore.dev/volume] [{csi.ironcore.dev/volume Apply storage.ironcore.dev/v1alpha1 2025-01-29 12:30:11 +0000 UTC FieldsV1 {"f:spec":{"f:resources":{"f:storage":{}},"f:volumeClassRef":{},"f:volumePoolRef":{}},"f:status":{}} } {volumepoollet Update storage.ironcore.dev/v1alpha1 2025-01-29 12:30:30 +0000 UTC FieldsV1 {"f:metadata":{"f:finalizers":{".":{},"v:\"volumepoollet.ironcore.dev/volume\"":{}}}} } {volumepoollet Update storage.ironcore.dev/v1alpha1 2025-01-29 12:30:33 +0000 UTC FieldsV1 {"f:status":{"f:access":{".":{},"f:driver":{},"f:handle":{},"f:secretRef":{},"f:volumeAttributes":{".":{},"f:image":{},"f:monitors":{}}},"f:lastStateTransitionTime":{},"f:state":{}}} status} {machinepoollet Update storage.ironcore.dev/v1alpha1 2025-01-30 16:21:55 +0000 UTC FieldsV1 {"f:spec":{"f:claimRef":{}}} }]} {&LocalObjectReference{Name:fast,} map[] &LocalObjectReference{Name:lab,} 0xc002d8f240 map[storage:{{10737418240 0} {<nil>} 10Gi BinarySI}]  nil false [] <nil>} {Available 2025-01-29 12:30:33 +0000 UTC 0xc0022fef60 []}} {{Volume storage.ironcore.dev/v1alpha1} {csi-ironcore-9ac42e4b6c  crs9  7e4ab1ed-28d2-4663-aad0-6825060d8d5c 499451758 0 2025-01-29 12:30:12 +0000 UTC <nil> <nil> map[] map[] [] [volumepoollet.ironcore.dev/volume] [{csi.ironcore.dev/volume Apply storage.ironcore.dev/v1alpha1 2025-01-29 12:30:12 +0000 UTC FieldsV1 {"f:spec":{"f:resources":{"f:storage":{}},"f:volumeClassRef":{},"f:volumePoolRef":{}},"f:status":{}} } {volumepoollet Update storage.ironcore.dev/v1alpha1 2025-01-29 12:30:32 +0000 UTC FieldsV1 {"f:metadata":{"f:finalizers":{".":{},"v:\"volumepoollet.ironcore.dev/volume\"":{}}}} } {volumepoollet Update storage.ironcore.dev/v1alpha1 2025-01-29 12:30:34 +0000 UTC FieldsV1 {"f:status":{"f:access":{".":{},"f:driver":{},"f:handle":{},"f:secretRef":{},"f:volumeAttributes":{".":{},"f:image":{},"f:monitors":{}}},"f:lastStateTransitionTime":{},"f:state":{}}} status} {machinepoollet Update storage.ironcore.dev/v1alpha1 2025-01-30 16:21:55 +0000 UTC FieldsV1 {"f:spec":{"f:claimRef":{}}} }]} {&LocalObjectReference{Name:fast,} map[] &LocalObjectReference{Name:lab,} 0xc002d8f260 map[storage:{{10737418240 0} {<nil>} 10Gi BinarySI}]  nil false [] <nil>} {Available 2025-01-29 12:30:34 +0000 UTC 0xc0022feff0 []}}]     {"controller": "machine", "controllerGroup": "compute.ironcore.dev", "controllerKind": "Machine", "Machine": {"name":"crs9-worker-lab1-674f5-58v9l","namespace":"crs9"}, "namespace": "crs9", "name": "crs9-worker-lab1-674f5-58v9l", "reconcileID": "222fd02e-944e-4055-8c7d-3604a4d432b0"}
2025-01-31T14:23:06Z    DEBUG   desiredIRIVolumes: []   {"controller": "machine", "controllerGroup": "compute.ironcore.dev", "controllerKind": "Machine", "Machine": {"name":"crs9-worker-lab1-674f5-58v9l","namespace":"crs9"}, "namespace": "crs9", "name": "crs9-worker-lab1-674f5-58v9l", "reconcileID": "222fd02e-944e-4055-8c7d-3604a4d432b0"}
2025-01-31T14:23:06Z    DEBUG   Detaching outdated IRI volume   {"controller": "machine", "controllerGroup": "compute.ironcore.dev", "controllerKind": "Machine", "Machine": {"name":"crs9-worker-lab1-674f5-58v9l","namespace":"crs9"}, "namespace": "crs9", "name": "crs9-worker-lab1-674f5-58v9l", "reconcileID": "222fd02e-944e-4055-8c7d-3604a4d432b0", "Volume": "primary"}
2025-01-31T14:23:06Z    DEBUG   events  Machine volumes are not ready: [csi-ironcore-14e6d01062-attachment csi-ironcore-514059d517-attachment csi-ironcore-7aec54aa41-attachment csi-ironcore-87ce08ae28-attachment csi-ironcore-debe2235dc-attachment]    {"type": "Normal", "object": {"kind":"Machine","namespace":"crs9","name":"crs9-worker-lab1-674f5-58v9l","uid":"d66a0c68-1d5e-4001-bc35-242cb0554229","apiVersion":"compute.ironcore.dev/v1alpha1","resourceVersion":"500531990"}, "reason": "VolumeNotReady"}
2025-01-31T14:23:06Z    DEBUG   Detaching outdated IRI volume   {"controller": "machine", "controllerGroup": "compute.ironcore.dev", "controllerKind": "Machine", "Machine": {"name":"crs9-worker-lab1-674f5-58v9l","namespace":"crs9"}, "namespace": "crs9", "name": "crs9-worker-lab1-674f5-58v9l", "reconcileID": "222fd02e-944e-4055-8c7d-3604a4d432b0", "Volume": "csi-ironcore-111345950a-attachment"}
2025-01-31T14:23:07Z    DEBUG   Detaching outdated IRI volume   {"controller": "machine", "controllerGroup": "compute.ironcore.dev", "controllerKind": "Machine", "Machine": {"name":"crs9-worker-lab1-674f5-58v9l","namespace":"crs9"}, "namespace": "crs9", "name": "crs9-worker-lab1-674f5-58v9l", "reconcileID": "222fd02e-944e-4055-8c7d-3604a4d432b0", "Volume": "csi-ironcore-aedbef721c-attachment"}
2025-01-31T14:23:07Z    DEBUG   Detaching outdated IRI volume   {"controller": "machine", "controllerGroup": "compute.ironcore.dev", "controllerKind": "Machine", "Machine": {"name":"crs9-worker-lab1-674f5-58v9l","namespace":"crs9"}, "namespace": "crs9", "name": "crs9-worker-lab1-674f5-58v9l", "reconcileID": "222fd02e-944e-4055-8c7d-3604a4d432b0", "Volume": "csi-ironcore-9ac42e4b6c-attachment"}
2025-01-31T14:23:08Z    DEBUG   Detaching outdated IRI volume   {"controller": "machine", "controllerGroup": "compute.ironcore.dev", "controllerKind": "Machine", "Machine": {"name":"crs9-worker-lab1-674f5-58v9l","namespace":"crs9"}, "namespace": "crs9", "name": "crs9-worker-lab1-674f5-58v9l", "reconcileID": "222fd02e-944e-4055-8c7d-3604a4d432b0", "Volume": "csi-ironcore-013a9aeaf9-attachment"}
2025-01-31T14:23:08Z    DEBUG   Detaching outdated IRI volume   {"controller": "machine", "controllerGroup": "compute.ironcore.dev", "controllerKind": "Machine", "Machine": {"name":"crs9-worker-lab1-674f5-58v9l","namespace":"crs9"}, "namespace": "crs9", "name": "crs9-worker-lab1-674f5-58v9l", "reconcileID": "222fd02e-944e-4055-8c7d-3604a4d432b0", "Volume": "csi-ironcore-1d01be69ef-attachment"}
2025-01-31T14:23:08Z    DEBUG   Detaching outdated IRI volume   {"controller": "machine", "controllerGroup": "compute.ironcore.dev", "controllerKind": "Machine", "Machine": {"name":"crs9-worker-lab1-674f5-58v9l","namespace":"crs9"}, "namespace": "crs9", "name": "crs9-worker-lab1-674f5-58v9l", "reconcileID": "222fd02e-944e-4055-8c7d-3604a4d432b0", "Volume": "csi-ironcore-018c0e70e9-attachment"}
2025-01-31T14:23:09Z    DEBUG   Detaching outdated IRI volume   {"controller": "machine", "controllerGroup": "compute.ironcore.dev", "controllerKind": "Machine", "Machine": {"name":"crs9-worker-lab1-674f5-58v9l","namespace":"crs9"}, "namespace": "crs9", "name": "crs9-worker-lab1-674f5-58v9l", "reconcileID": "222fd02e-944e-4055-8c7d-3604a4d432b0", "Volume": "csi-ironcore-30c3b9a9cd-attachment"}
2025-01-31T14:23:09Z    DEBUG   Detaching outdated IRI volume   {"controller": "machine", "controllerGroup": "compute.ironcore.dev", "controllerKind": "Machine", "Machine": {"name":"crs9-worker-lab1-674f5-58v9l","namespace":"crs9"}, "namespace": "crs9", "name": "crs9-worker-lab1-674f5-58v9l", "reconcileID": "222fd02e-944e-4055-8c7d-3604a4d432b0", "Volume": "csi-ironcore-bfc65e91cd-attachment"}

As you can see in logs machinepoollet load volumes from user api cluster properly but inside of reconcile logic for volume it returned empty desired volumes slice in line: https://github.com/ironcore-dev/ironcore/blob/main/poollet/machinepoollet/controllers/machine_controller_volume.go#L315

This empty desired volumes are later used in function getExistingIRIVolumesForMachine which will call detach volumes because desired volumes are empty.

Problem code is in function prepareIRIVolumes on line https://github.com/ironcore-dev/ironcore/blob/main/poollet/machinepoollet/controllers/machine_controller_volume.go#L233

If count of iriVolumes is different as count of volumes in spec, function won't return any desired volumes.

To Reproduce
Ceph volumes without status or secret are skipped in function https://github.com/ironcore-dev/ironcore/blob/main/poollet/machinepoollet/controllers/machine_controller_volume.go#L209

Expected behavior
Volumes aren't deleted, if volumes on user api level doesn't have deletetion timestamp and they weren't detached.

Additional context
In our lab was bug trigger little randomly and we weren't able to simulate it always with standard attaching/detaching volumes into vm.

@lukas016 lukas016 added the bug Something isn't working label Feb 5, 2025
@ushabelgur ushabelgur self-assigned this Feb 7, 2025
@ushabelgur
Copy link
Contributor

Observation from side:
This issue is happening in case of update scenario, when all IRI machine along with IRI volume was available, then some problem with one single/some volumes(volumes without access or secret) happens, this IRI volume list is recalculate but this logic has a problem and it is returning empty list. Because of which all the disks are getting detached in later flow. Returning correct desired list of IRI volumes should fix this problem.

@afritzler afritzler changed the title all ceph disks are detach from virtual machine All disks might be detached from Machine Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants