Skip to content

Fix bug in comm based server side validation, #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2016

Conversation

jdfreder
Copy link
Contributor

which was causing "Widget Javascript not detected" to be
printed to the console despite the Javascript being
installed correctly

cc @SylvainCorlay

which was causing "Widget Javascript not detected" to be
printed to the console despite the Javascript being
installed correctly
@jdfreder jdfreder added this to the 5.0 milestone Jan 14, 2016
@SylvainCorlay
Copy link
Member

👍
We could define this loud error outside of the function (and make it a loud warning :) ). For deprecations like #288, users should not have to enable warning manually.

@jdfreder
Copy link
Contributor Author

For deprecations like #288, users should not have to enable warning manually.

I think the difference between this and that is that this also uses self.log.warn, which prints to the server's terminal window. I do this because I want to make sure that the message is seen somewhere.

minrk added a commit that referenced this pull request Jan 15, 2016
Fix bug in comm based server side validation,
@minrk minrk merged commit c6794d5 into jupyter-widgets:master Jan 15, 2016
@minrk
Copy link
Contributor

minrk commented Jan 15, 2016

@SylvainCorlay IPython should be showing deprecation warnings by default if they are caused directly by user code.

@github-actions github-actions bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 26, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kernel authors beware resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants