fix: make toV0 and toV1 return CID objects

multiformats · Jan 21, 2017 · 32902e3 · 32902e3
1 parent 3e0492f
commit 32902e3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/src/index.js b/src/index.js
@@ -85,11 +85,15 @@ class CID {
   }
 
   toV0 () {
-    return this.multihash
+    if (this.codec !== 'dag-pb') {
+      throw new Error('Cannot convert a non dag-pb CID to CIDv0')
+    }
+
+    return new CID(0, this.codec, this.multihash)
   }
 
   toV1 () {
-    return this.buffer
+    return new CID(1, this.codec, this.multihash)
   }
 
   /* defaults to base58btc */

diff --git a/test/index.spec.js b/test/index.spec.js
@@ -136,15 +136,11 @@ describe('CID', () => {
     it('.equals v0 to v1 and vice versa', () => {
       const cidV1Str = 'zdj7Wd8AMwqnhJGQCbFxBVodGSBG84TM7Hs1rcJuQMwTyfEDS'
       const cidV1 = new CID(cidV1Str)
-      const cidV0 = new CID(cidV1.toV0())
+      const cidV0 = cidV1.toV0()
 
-      expect(
-        cidV0.equals(cidV1)
-      ).to.be.eql(false)
+      expect(cidV0.equals(cidV1)).to.be.false
 
-      expect(
-        cidV1.equals(cidV0)
-      ).to.be.eql(false)
+      expect(cidV1.equals(cidV0)).to.be.false
 
       expect(cidV1.multihash).to.eql(cidV0.multihash)
     })