fix: throw an error if another base is picked for cidv0

multiformats · Jan 21, 2017 · 24f2c0b · 24f2c0b
1 parent 451e1ea
commit 24f2c0b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/index.js b/src/index.js
@@ -97,8 +97,12 @@ class CID {
     base = base || 'base58btc'
 
     switch (this.version) {
-      case 0:
+      case 0: {
+        if (base !== 'base58btc') {
+          throw new Error('not supported with CIDv0, to support different bases, please migrate the instance do CIDv1, you can do that through cid.toV1()')
+        }
         return mh.toB58String(this.multihash)
+      }
       case 1:
         return multibase.encode(base, this.buffer).toString()
       default:

diff --git a/test/index.spec.js b/test/index.spec.js
@@ -50,6 +50,12 @@ describe('CID', () => {
       ).to.throw()
     })
 
+    it('throws on trying to base encode CIDv0 in other base than base58 ', () => {
+      const mhStr = 'QmdfTbBqBPQ7VNxZEYEj14VmRuZBkqFbiwReogJgS1zR1n'
+      const cid = new CID(mhStr)
+      expect(() => cid.toBaseEncodedString('base16')).to.throw()
+    })
+
     it('.prefix', () => {
       const cid = new CID(0, 'dag-pb', multihash.encode(new Buffer('abc'), 'sha2-256'))
       expect(cid.prefix.toString('hex')).to.equal('00701203')