make reader lazy on fs.read to run ignore polyfill #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
reviewed
Dec 30, 2024
rvagg
reviewed
Dec 30, 2024
rvagg
reviewed
Dec 30, 2024
rvagg
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
I've been trying to figure out why __browser is there and I'm scratching my head a bit. I think it's only for tests, to assert that when run in the different environments that it's loading the right thing, but that's only tested from reader.js so I'm not sure it really serves a useful purpose.
But that's probably an issue to resolve some other time!
github-actions bot
pushed a commit
that referenced
this pull request
Jan 6, 2025
## [5.4.0](v5.3.3...v5.4.0) (2025-01-06) ### Features * make reader lazy on fs.read to run ignore polyfill ([#168](#168)) ([ccb8edc](ccb8edc))
|
🎉 This PR is included in version 5.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have a problem with running @ipld/car in Cloudflare workers.
In a lovely world the internal esbuild of wrangler should pick the browser implementation.
But the reality is that wrangler/esbuild picks the node implementation and provides a polyfill for the node
imports that will cause:
this error:
So I made it lazy and set __browser.