Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Could not add migration to IPFS: Cannot get migrations from unknown fetcher type #8780

Closed
lidel opened this issue Mar 9, 2022 · 2 comments · Fixed by #8830
Closed

Could not add migration to IPFS: Cannot get migrations from unknown fetcher type #8780

lidel opened this issue Mar 9, 2022 · 2 comments · Fixed by #8830
Labels
kind/bug A bug in existing code (including security flaws) need/analysis Needs further analysis before proceeding need/triage Needs initial labeling and prioritization
Milestone
go-ipfs 0.13

Comments

@lidel
Copy link
Member

lidel commented Mar 9, 2022 •
edited
Loading

Version

0.12.0

Description

Could not add migration to IPFS: Cannot get migrations from unknown fetcher type

Above message was reported by Brave and on https://develop.element.io/#/room/#lobby:ipfs.io:

2022-03-09_20-59

2022-03-09_20-59_1

It does not impact migration itself, but raises a concern that something went wrong.

In this case, downloaded migration is not added to IPFS, so other machines from LAN can't fetch it locally p2p, but need to fetch from swarm/HTTP. Not a hard error, but something we should fix to improve resilience.

Relevant code:
@lidel lidel added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization need/analysis Needs further analysis before proceeding labels Mar 9, 2022
@lidel
Copy link
Member Author

lidel commented Mar 9, 2022

@gammazero any ideas? is this a bug because we do type assertion over pointer here?

@lidel lidel moved this to 🏃‍♀️ In Progress in IPFS Shipyard Team Mar 9, 2022
@lidel lidel added this to the go-ipfs 0.13 milestone Mar 9, 2022
@lidel lidel moved this from 🏃‍♀️ In Progress to 🥞 Todo in IPFS Shipyard Team Mar 10, 2022
@gammazero
Copy link
Contributor

@lidel I am guessing this happens because fetcher here is nil, and that if above should check that.

This was referenced Mar 28, 2022
Closed
Merged
Repository owner moved this from 🥞 Todo to 🎉 Done in IPFS Shipyard Team Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws) need/analysis Needs further analysis before proceeding need/triage Needs initial labeling and prioritization
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
go-ipfs 0.13
Development

Successfully merging a pull request may close this issue.

fix: unknown fetcher type error ipfs/kubo
2 participants
@lidel @gammazero