Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webui problems #753

Closed
1 of 6 tasks
jbenet opened this issue Feb 6, 2015 · 15 comments
Closed
1 of 6 tasks

Webui problems #753

jbenet opened this issue Feb 6, 2015 · 15 comments

Comments

@jbenet
Copy link
Member

jbenet commented Feb 6, 2015

@mappum these are webui problems:

  • old hashes should remain allowed for users who have links
  • there should be a "how to publish a new webui" section in a readme inside corehttp/.
  • there should be a Makefile in ipfs-webui that npm installs and delegates to gulp. typing make is the only think we can expect developers to know.
  • there should be a make bundle makefile target in ipfs-webui that compiles, and prints out instructions to the user on how to publish the webui. ipfs add -r
  • there should be a make publish makefile target in ipfs-webui that compiles the bundle, + publishes the hashes for you, assuming you have an ipfs daemon running.
  • before publishing any webui make sure it's served on the gateway. the latest hash is simply not available, and i dont know how to build it. the current build/ does not match the hash you put in.

Please be more careful with these things. they break on users. and i can't even fix it right now. 😢

@jbenet
Copy link
Member Author

jbenet commented Feb 6, 2015

  • no hardcoding of hostnames or ports. webui should work with whatever host its on. (so should ipfs-api)

@mappum
Copy link
Contributor

mappum commented Feb 7, 2015

@jbenet Aren't make bundle and make publish the same thing? Do you mean publishing via IPNS?

@jbenet
Copy link
Member Author

jbenet commented Feb 7, 2015

i'm thinking something like:

bundle: build/bundle.js build/index.html ...

build/bundle.js: deps
    node_modules/.bin/gulp compile

publish: bundle
    hash=`ipfs add -q -r build/ | tail -n1` && echo "published at $hash"

@mappum
Copy link
Contributor

mappum commented Feb 7, 2015

I'm not sure where the bundle indeterminism is coming from, I thought that was previously solved. It might be easier to just be able to push a hash to the gateways, then they can get and pin the refs, rather than expecting them to build the same bundle.

@jbenet
Copy link
Member Author

jbenet commented Feb 7, 2015

and you're for sure at deabd49 ? do you get different bundles with different runs?

@mappum
Copy link
Contributor

mappum commented Feb 7, 2015

and you're for sure at deabd49 ?

Yes.

do you get different bundles with different runs?

Re-cloning the repo and npm installing changed the bundle, but repeating that always gets the same output. The hash I'm getting is QmbjEC2EeMNcLonYyRgbUjoxeeN1YSRN2pVUw9ze9JivFn.

@jbenet
Copy link
Member Author

jbenet commented Feb 7, 2015

npm installing changed the bundle

yeah this seems flakey. what if we fix to exact versions of stuff in the package.json?

@mappum
Copy link
Contributor

mappum commented Feb 7, 2015

yeah this seems flakey. what if we fix to exact versions of stuff in the package.json?

Alright, that might be where the changes are coming from.

@mappum
Copy link
Contributor

mappum commented Feb 7, 2015

Actually I'm not sure that will solve it, since 2nd level dependencies are likely not fixed to exact versions, and will suffer the same problem.

@jbenet
Copy link
Member Author

jbenet commented Feb 7, 2015

then maybe we should commit + keep all the built versions:

versions/QmbjEC2EeMNcLonYyRgbUjoxeeN1YSRN2pVUw9ze9JivFn/...
versions/...

so that we can make sure we can republish any of them should we need to.

@mappum
Copy link
Contributor

mappum commented Feb 7, 2015

Alright, I added the latest bundle to the repo. Now the gateways should just ipfs add -r versions whenever the repo changes, and all bundle versions will be available.

@jbenet
Copy link
Member Author

jbenet commented Feb 7, 2015

:m1:

mappum: do you have the old ones?

also, npm install never terminates for me...

@mappum
Copy link
Contributor

mappum commented Feb 7, 2015

do you have the old ones?

Nope. We can just update the hash in go-ipfs and start supporting all versions after this one.

also, npm install never terminates for me...

You might need to update npm? Mine is on v2.5.0.

@jbenet
Copy link
Member Author

jbenet commented Feb 7, 2015

We can just update the hash in go-ipfs and start supporting all versions after this one.

@mappum sgtm. I have one still. just pushed it to protocol/ipfs-webui (i'd push it to yours but git tells me i cant)

@jbenet
Copy link
Member Author

jbenet commented Mar 28, 2015

this should be moved to protocol/ipfs-webui

@jbenet jbenet closed this as completed Mar 28, 2015
@aschmahmann aschmahmann mentioned this issue Dec 1, 2021
80 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants