-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webui problems #753
Comments
|
@jbenet Aren't |
i'm thinking something like: bundle: build/bundle.js build/index.html ...
build/bundle.js: deps
node_modules/.bin/gulp compile
publish: bundle
hash=`ipfs add -q -r build/ | tail -n1` && echo "published at $hash" |
I'm not sure where the bundle indeterminism is coming from, I thought that was previously solved. It might be easier to just be able to push a hash to the gateways, then they can get and pin the refs, rather than expecting them to build the same bundle. |
and you're for sure at |
Yes.
Re-cloning the repo and |
yeah this seems flakey. what if we fix to exact versions of stuff in the |
Alright, that might be where the changes are coming from. |
Actually I'm not sure that will solve it, since 2nd level dependencies are likely not fixed to exact versions, and will suffer the same problem. |
then maybe we should commit + keep all the built versions:
so that we can make sure we can republish any of them should we need to. |
Alright, I added the latest bundle to the repo. Now the gateways should just |
:m1: mappum: do you have the old ones? also, |
Nope. We can just update the hash in
You might need to update |
@mappum sgtm. I have one still. just pushed it to |
this should be moved to protocol/ipfs-webui |
@mappum these are webui problems:
corehttp/
.Makefile
in ipfs-webui that npm installs and delegates to gulp. typingmake
is the only think we can expect developers to know.make bundle
makefile target inipfs-webui
that compiles, and prints out instructions to the user on how to publish the webui.ipfs add -r
make publish
makefile target inipfs-webui
that compiles the bundle, + publishes the hashes for you, assuming you have anipfs daemon
running.build/
does not match the hash you put in.Please be more careful with these things. they break on users. and i can't even fix it right now. 😢
The text was updated successfully, but these errors were encountered: