Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential go routine leak in pin/gc/gc.go #4593

Closed
Stebalien opened this issue Jan 18, 2018 · 1 comment
Closed

Potential go routine leak in pin/gc/gc.go #4593

Stebalien opened this issue Jan 18, 2018 · 1 comment
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@Stebalien
Copy link
Member

We have a channel with a magic buffer-size number. We can block indefinitely if the context is canceled and the output channel is full (and we try to write an error). We need to select on the context instead of relying on the buffer (and not defer closing the channel as per #4592).
@Stebalien
Copy link
Member Author

Specifically, in the GC function.

@Stebalien Stebalien mentioned this issue Jan 18, 2018
Merged
@Stebalien Stebalien added the kind/bug A bug in existing code (including security flaws) label Jan 30, 2018
@overbool overbool mentioned this issue Sep 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Stebalien