Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

ipfs.add vs ipfs.addAll input types #3290

Closed
achingbrain opened this issue Sep 18, 2020 · 2 comments · Fixed by #3900
Closed

ipfs.add vs ipfs.addAll input types #3290

achingbrain opened this issue Sep 18, 2020 · 2 comments · Fixed by #3900
Labels
kind/enhancement A net-new feature or improvement to an existing feature status/ready Ready to be worked

Comments

@achingbrain
Copy link
Member

Currently ipfs.add will pass it's input to ipfs.addAll and return the last result.

Instead it should detect if it's been passed something that will yield multiple results and throw.

Refs: ProtoSchool/protoschool.github.io#498
@achingbrain achingbrain added the need/triage Needs initial labeling and prioritization label Sep 18, 2020
@achingbrain achingbrain added kind/enhancement A net-new feature or improvement to an existing feature status/ready Ready to be worked and removed need/triage Needs initial labeling and prioritization labels Sep 18, 2020
@terichadbourne
Copy link
Contributor

👋 @achingbrain Just checking in on the status of this one as we still have an open ProtoSchool issue to update the Regular Files API tutorial accordingly when we figure out the plan.

@achingbrain
Copy link
Member Author

This will (finally) be fixed by #3900

@achingbrain achingbrain linked a pull request Sep 28, 2021 that will close this issue
fix: do not accept single items for ipfs.add #3900
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/enhancement A net-new feature or improvement to an existing feature status/ready Ready to be worked
Projects
No open projects
JS IP Board (deprecated)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: do not accept single items for ipfs.add ipfs/js-ipfs
2 participants
@achingbrain @terichadbourne