fix: do not add metadata to leaves #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an imported file is big enough to need leaf nodes, and that file is imported with metadata, we should only add that metadata to the root of the file DAG and not to every leaf in the graph.
|
@achingbrain I think this should probably go as |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 26, 2022
## [ipfs-unixfs-importer-v9.0.7](ipfs-unixfs-importer-v9.0.6...ipfs-unixfs-importer-v9.0.7) (2022-04-26) ### Bug Fixes * do not add metadata to leaves ([#193](#193)) ([f5d3a67](f5d3a67)) * don't split paths on `^` characters ([#192](#192)) ([9a69908](9a69908)) ### Trivial Changes * switch to auto-release ([#208](#208)) ([99386e6](99386e6)) * switch to gh actions ([#175](#175)) ([395852b](395852b)) * update readmes ([#188](#188)) ([273a141](273a141))
|
🎉 This PR is included in version ipfs-unixfs-importer-v9.0.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 26, 2022
## [ipfs-unixfs-exporter-v7.0.7](ipfs-unixfs-exporter-v7.0.6...ipfs-unixfs-exporter-v7.0.7) (2022-04-26) ### Bug Fixes * do not add metadata to leaves ([#193](#193)) ([f5d3a67](f5d3a67)) ### Trivial Changes * switch to auto-release ([#208](#208)) ([99386e6](99386e6)) * update readmes ([#188](#188)) ([273a141](273a141))
|
🎉 This PR is included in version ipfs-unixfs-exporter-v7.0.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an imported file is big enough to need leaf nodes, and that
file is imported with metadata, we should only add that metadata
to the root of the file DAG and not to every leaf in the graph.