This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
fix: correct hamt structure when modifying deep sub-shards #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
achingbrain
force-pushed
the
fix-shard-updating
branch
2 times, most recently
from
7a32304 to
8bb576c
Compare
If you have a shard like:
```
F1
A0
C8myfile
```
And you add a file that causes `C8myfile` to become a subshard, previously
you would end up with this:
```
F1
A0
C8
C8
B3myfile
82newfile
```
This PR ensures you get the correct structure:
```
F1
A0
C8
B3myfile
82newfile
```
When we update a shard, we re-create a portion of the shard in order to
update the existing structure, this avoids loading the entire shard which
could be expensive. Previously we weren't descending into the newly
created sub-shard to add the correct portion to the existing shard.
Fixes #45
achingbrain
force-pushed
the
fix-shard-updating
branch
from
8bb576c to
4dd2b72
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a shard like:
And you add a file that causes
C8myfileto become a subshard, previously you would end up with this:This PR ensures you get the correct structure:
When we update a shard, we re-create a portion of the shard in order to update the existing structure, this avoids loading the entire shard which could be expensive. Previously we weren't descending into the newly created sub-shard to add the correct portion to the existing shard.
Fixes #45