Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken CID info for identity multihashes #464

Closed
Tracked by #10580
lidel opened this issue Nov 29, 2024 · 1 comment · Fixed by #465
Closed
Tracked by #10580

Broken CID info for identity multihashes #464

lidel opened this issue Nov 29, 2024 · 1 comment · Fixed by #465
Assignees
Labels
kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization P1 High: Likely tackled by core team if no one steps up

Comments

@lidel
Copy link
Member

lidel commented Nov 29, 2024

Inspecting a CID with identity multihash (like bafkqaddjnzzxazldoqwxizltoq or bafkqablimvwgy3y) produces error and breaks "CID info" section:

image

@lidel lidel added kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up labels Nov 29, 2024
@lidel
Copy link
Member Author

lidel commented Nov 29, 2024

I think maybe

export type SupportedHashers = typeof sha2.sha256 |
typeof sha2.sha512 |
Hasher<'keccak-256', 27> |
Hasher<'sha1', 17> |
Hasher<'blake2b-256', 0xb220> |
Hasher<'blake2b-512', 0xb240> |
Hasher<'sha3-512', 20> |
Hasher<'blake3', 30>

is missing https://github.com/multiformats/js-multiformats/blob/master/src/hashes/identity.ts ?

Anyway, @SgtPooki mind taking a look at this next week, and if easy to fix, tag a patch release? 🙏

@lidel lidel added the need/triage Needs initial labeling and prioritization label Nov 29, 2024
@lidel lidel mentioned this issue Nov 29, 2024
60 tasks
@SgtPooki SgtPooki self-assigned this Dec 2, 2024
@SgtPooki SgtPooki linked a pull request Dec 2, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization P1 High: Likely tackled by core team if no one steps up
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants