Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX bug - regex not matching a correct peer address #2195

Closed
koxon opened this issue Jan 20, 2024 · 1 comment · Fixed by #2199
Closed

UX bug - regex not matching a correct peer address #2195

koxon opened this issue Jan 20, 2024 · 1 comment · Fixed by #2199
Assignees
Labels
area/screen/peers Issues related to Peers screen dependencies Pull requests that update a dependency file kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP status/ready Ready to be worked

Comments

@koxon
Copy link

koxon commented Jan 20, 2024

Describe the bug
If the peer address contains /quick-v1/ instead of /quick/ the field can't be validated and remains in error

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'PEERS'
  2. Click on 'Add connection'
  3. Try to add an address that contains /quick-v1/. Here is one: /ip4/54.90.162.249/udp/4001/quic-v1/p2p/12D3KooWS2xWyVAQA1Hr52mM52hxpBvV5fvrWPeZF1Ck8jes6LrH
  4. See error

Expected behavior
latest version of ipfs creates those address so they should be supported

Screenshots
image

Desktop (please complete the following information):

  • OS: Mac Os
  • Browser chrome
  • Version 0.32
@koxon koxon added the need/triage Needs initial labeling and prioritization label Jan 20, 2024
Copy link

welcome bot commented Jan 20, 2024

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

@github-project-automation github-project-automation bot moved this to Needs Grooming in IPFS-GUI (PL EngRes) Jan 20, 2024
@SgtPooki SgtPooki added kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP status/ready Ready to be worked dependencies Pull requests that update a dependency file and removed need/triage Needs initial labeling and prioritization labels Feb 2, 2024
@SgtPooki SgtPooki moved this from Needs Grooming to In Progress in IPFS-GUI (PL EngRes) Feb 2, 2024
@SgtPooki SgtPooki self-assigned this Feb 2, 2024
@SgtPooki SgtPooki added the area/screen/peers Issues related to Peers screen label Feb 2, 2024
@SgtPooki SgtPooki linked a pull request Feb 2, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in IPFS-GUI (PL EngRes) Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/screen/peers Issues related to Peers screen dependencies Pull requests that update a dependency file kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP status/ready Ready to be worked
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants