Set fileDescriptor.closed=true in Close() method.

[nitishm]

go-mfs/fd.go

Line 41 in e5a375d

closed bool

The fileDescriptor.closed member is never set to anything other than false (by the constructor).

go-mfs/fd.go

Lines 85 to 114 in e5a375d

	func (fi *fileDescriptor) Close() error {
	defer func() {
	switch fi.perms {
	case OpenReadOnly:
	fi.inode.desclock.RUnlock()
	case OpenWriteOnly, OpenReadWrite:
	fi.inode.desclock.Unlock()
	}
	// TODO: `closed` should be set here.
	}()
	if fi.closed {
	panic("attempted to close file descriptor twice!")
	}
	if fi.hasChanges {
	err := fi.mod.Sync()
	if err != nil {
	return err
	}
	fi.hasChanges = false
	// explicitly stay locked for flushUp call,
	// it will manage the lock for us
	return fi.flushUp(fi.sync)
	}
	return nil
	}

The only place I can think of this value getting set is in the Close() method. If there is agreement we can set it to true here.

If there is no other use case of the closed member we should just eliminate it.

[nitishm]

@schomatis @Stebalien Do you guys agree ?

[schomatis]

@nitishm Thanks for raising this issue so it doesn't get lost in the TODO comments, let's punt on this a bit after we review the entire way the file descriptor operates in #8.

[nitishm]

@schomatis @Stebalien I think this can be closed. Its no longer an issue after merging #49

[schomatis]

Yes!