You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When we switch the blockstore over to use multihashes instead of Cids the Deletes from a Dagservice that is backed by a blockstore will become problematic.
The dagservice has a Delete method. This is problematic. For example if you insert a raw and a Protobuf version of the same Node then delete the one of those nodes via the dagservice both will be deleted. We should probably delete these methods. The only place the Delete method seams to be used is in dagutils/utils.go. I have marked two of the three instances with comments.
Does the delete methods serve a useful purpose?
The text was updated successfully, but these errors were encountered:
When we switch the blockstore over to use multihashes instead of Cids the Deletes from a Dagservice that is backed by a blockstore will become problematic.
From ipfs/kubo#5510:
Does the delete methods serve a useful purpose?
The text was updated successfully, but these errors were encountered: