-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(node/libp2p): disable rcmg checkImplicitDefaults #8965
Conversation
2d972ba
to
245e7da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, we should remove runtime check, and then do proper fix in #8954.
Let's wait for CI, then merge.
@@ -32,6 +32,7 @@ default_environment: &default_environment | |||
CIRCLE_TEST_REPORTS: /tmp/circleci-test-results | |||
CIRCLE_ARTIFACTS: /tmp/circleci-artifacts | |||
GIT_PAGER: cat | |||
IPFS_CHECK_RCMGR_DEFAULTS: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this so we keep running old runtime checker on our CI until #8954 is fully baked.
dc58dc7
to
28a71e8
Compare
e2e was failing because of runtime resource manager checks we disabled since -rc1: ipfs/kubo#8965
fix(node/libp2p): disable rcmgr checkImplicitDefaults
fix(node/libp2p): disable rcmgr checkImplicitDefaults (cherry picked from commit e23a461)
fix(node/libp2p): disable rcmgr checkImplicitDefaults (cherry picked from commit e23a461)
fix(node/libp2p): disable rcmgr checkImplicitDefaults (cherry picked from commit e23a461)
Quick band-aid for #8949 to fix master before #8954 lands.