feat: detect default limit changes in go-libp2p-resource-manager #8857
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8761, based on #8680
What
This PR removes hardcoded defaults and switches to ones from go-libp2p.
To safeguard against silent changes that could impact our users, adds a simple check that will scream loud and clear every time go-libp2p libraries change any of the limit defaults related to go-libp2p-resource-manager. This was suggested during recent go-ipfs sync.
How
but given how many values we have it was difficult to spot the change.
Demo
Assuming next version of go-libp2p changed:
The daemon will refuse to start until the changes are reviewed, and expected values are updated in
rcmgr_defaults.go
: