-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update go-libp2p to v0.15.0-rc.1 #8354
Conversation
github.com/multiformats/go-multiaddr-dns v0.3.1 | ||
github.com/multiformats/go-multibase v0.0.3 | ||
github.com/multiformats/go-multicodec v0.3.0 | ||
github.com/multiformats/go-multihash v0.0.15 | ||
github.com/opentracing/opentracing-go v1.2.0 | ||
github.com/pkg/errors v0.9.1 | ||
github.com/prometheus/client_golang v1.10.0 | ||
github.com/prometheus/client_golang v1.11.0 | ||
github.com/prometheus/statsd_exporter v0.21.0 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand why, but I had to manually run go get github.com/prometheus/[email protected]
, since I was getting this error:
❯ go mod tidy
go: finding module for package github.com/prometheus/common/log
github.com/ipfs/go-ipfs/core/corehttp imports
contrib.go.opencensus.io/exporter/prometheus imports
github.com/prometheus/statsd_exporter/pkg/mapper imports
github.com/prometheus/common/log: module github.com/prometheus/common@latest found (v0.30.0), but does not contain package github.com/prometheus/common/log
a15a733
to
4fd3916
Compare
We probably need to bump the version of Go on the go mod file to 1.16 also, right? We can wait on CI to do it's initial run though |
e81399e
to
abaf5e1
Compare
Done. |
d0ad0a8
to
ce868b1
Compare
core/node/libp2p/addrs.go
Outdated
return filter, opts, nil | ||
var opts Libp2pOpts | ||
opts.Opts = append(opts.Opts, libp2p.ConnectionGater(gater)) | ||
return ma.NewFilters(), opts, nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is failing because the returned ma.Filters
has no impact on the ConnectionGater at all. This means all the commands relying on n.Filters
to interact with the connection gater are failing.
Here was the previously used connection gater that exposed that information via the passed in ma.Filters
https://github.com/libp2p/go-libp2p/blob/v0.14.4/options_filter.go
66b39fe
to
c95d6ca
Compare
update go-libp2p to v0.15.0-rc.1 This commit was moved from ipfs/kubo@956c248
No description provided.