Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump snap to build with Go 1.16 #8212

Merged
merged 1 commit into from
Jun 23, 2021
Merged

bump snap to build with Go 1.16 #8212

merged 1 commit into from
Jun 23, 2021

Conversation

aschmahmann
Copy link
Contributor

No description provided.

@aschmahmann aschmahmann requested a review from olizilla June 23, 2021 14:03
Copy link
Member

@olizilla olizilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should build out to the edge channel. If you're happy that master is close enough to the 0.9.0 release, then we can manually promote the build from the edge channel to the stable channel. We include the partial commit sha that a releae is from in the build name, which wont match a commit on the release branch, but if it bothers anyone, we can point them to this thread.

@olizilla
Copy link
Member

ah, from @aschmahmann

IIUC promoting won't work here since we'll only see master and that will have a version of v0.10.0-dev instead of v0.9.0

@aschmahmann aschmahmann merged commit d9f28a2 into master Jun 23, 2021
@aschmahmann aschmahmann mentioned this pull request Jul 16, 2021
18 tasks
@hacdias hacdias deleted the chore/snap-update-go branch May 9, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants