Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update deps #7941

Merged
merged 2 commits into from
Feb 26, 2021
Merged

chore: update deps #7941

merged 2 commits into from
Feb 26, 2021

Conversation

Stebalien
Copy link
Member

Primarily,

  • update semver (go mod support)
  • update graphsync & go-ipld-prime
  • update golang.org/x packages.

@aschmahmann
Copy link
Contributor

@Stebalien it looks like we're still trying to build for GOOS=darwin GOARCH=386 which is what's causing the build failure here.

@aschmahmann
Copy link
Contributor

#7944 is required first

@Stebalien
chore: update deps
01403e9 
Primarily,

* update semver (go mod support)
* update graphsync & go-ipld-prime
* update golang.org/x packages.
@Stebalien Stebalien requested a review from gammazero February 26, 2021 01:22
@Stebalien
build: drop support for darwin-386
a895bac 
The new sys package drops support.
warpfork
warpfork approved these changes Feb 26, 2021
View reviewed changes
Copy link
Member

@warpfork warpfork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a case of "tests pass -> lgtm"?

@Stebalien Stebalien merged commit 6e99535 into master Feb 26, 2021
@Stebalien Stebalien deleted the chore/update-deps branch February 26, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warpfork warpfork warpfork approved these changes

@aschmahmann aschmahmann Awaiting requested review from aschmahmann

@gammazero gammazero Awaiting requested review from gammazero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Stebalien @aschmahmann @warpfork