sharness: use dnsaddr example in ipfs p2p command tests #7620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…address in it to use a specific example
aschmahmann
commented
Aug 24, 2020
| @@ -84,7 +84,7 @@ test_expect_success 'S->C Setup(dnsaddr/addr/p2p/peerID) client side' ' | |||
| ' | |||
|
|
|||
| test_expect_success 'S->C Setup(dnsaddr/addr) client side' ' | |||
| ipfsi 1 p2p forward /x/p2p-test /ip4/127.0.0.1/tcp/10104 /dnsaddr/cluster.ipfs.io 2>&1 > dialer-stdouterr.log | |||
There was a problem hiding this comment.
I only changed this one and not the one above since that one has multiple addresses. It turns out it doesn't really matter what address this record points to (online or not) for this test, so as long as this example record is stable with a single entry we should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.