Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(commands): print consistent addresses in ipfs id #7397

Merged
merged 2 commits into from
Jun 2, 2020
Merged

fix(commands): print consistent addresses in ipfs id #7397

merged 2 commits into from
Jun 2, 2020

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented May 30, 2020 •
edited
Loading

Consistently append /p2p/QmMyId to addresses when calling ipfs id Me and ipfs id NotMe.

Fixes #7378.

@Stebalien
fix(commands): print consistent addresses in ipfs id
3aa86f8 
Consistently append `/p2p/QmMyId` to addresses when calling `ipfs id Me` and `ipfs id NotMe`.

Fixes #7378.
@Stebalien Stebalien force-pushed the fix/id-addr-format branch from a691024 to 3aa86f8 Compare May 30, 2020 01:49
@Stebalien Stebalien requested a review from achingbrain May 30, 2020 01:49
achingbrain
achingbrain requested changes Jun 2, 2020
View reviewed changes
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests only test that the output of ipfs id is the same for local and remote nodes, not that /p2p/ is prepended to the id in the output as the PR description says?

@Stebalien
Copy link
Member Author

Well, the test is to fix the issue where ipfs id and ipfs id remote_peer were inconsistent. However, you're right. I don't think we have any tests that directly check if these addresses contain /p2p. I'll add another test.

@Stebalien Stebalien merged commit 22dc1ad into master Jun 2, 2020
@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
Closed
72 tasks
@fabianhjr fabianhjr mentioned this pull request Nov 2, 2020
Closed
10 tasks
@hacdias hacdias deleted the fix/id-addr-format branch May 9, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achingbrain achingbrain achingbrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"ipfs id" address format is inconsistent
2 participants
@Stebalien @achingbrain