Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc config/experimental-features doc fixes #7333

Merged
merged 3 commits into from
May 20, 2020
Merged

misc config/experimental-features doc fixes #7333

merged 3 commits into from
May 20, 2020

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented May 20, 2020 •
edited
Loading

  • sort config sections (ignore that commit when reviewing)
  • add a pubsub config section
  • update pubsub experimental feature.

@Stebalien Stebalien requested a review from aschmahmann May 20, 2020 02:28
aschmahmann
aschmahmann approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@aschmahmann aschmahmann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall seems reasonable to me. Two things I might add, but that we could do in another PR are:

  1. Update the IPNS over PubSub experimental text
  2. Reading through the diff in the GitHub UI is awful because some of our JSON isn't properly formatted (e.g. a } is missing from https://github.com/ipfs/go-ipfs/blob/doc/misc-fixes/docs/config.md#gatewaypathprefixes). We may want to clean these up.

lmk if you want me to do either of these changes or review them if you do them. Otherwise, LGTM

@Stebalien Stebalien merged commit 55f64ba into master May 20, 2020
@Stebalien
Copy link
Member Author

@aschmahmann feel free to make those changes (and any other doc cleanups, we have many...)

@Stebalien Stebalien mentioned this pull request May 26, 2020
Closed
77 tasks
@hacdias hacdias deleted the doc/misc-fixes branch May 9, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschmahmann aschmahmann aschmahmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @aschmahmann