docs: fix subdomain examples in CHANGELOG #7240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
commented
Apr 28, 2020
Stebalien
reviewed
Apr 28, 2020
| @@ -226,13 +226,13 @@ In addition to a bunch of bug fixes, we've made two improvements to the gateway. | |||
|
|
|||
| You can play with both of these features by visiting: | |||
|
|
|||
| > http://bafybeia6po64b6tfqq73lckadrhpihg2oubaxgqaoushquhcek46y3zumm.ipfs.io/ | |||
| > http://bafybeia6po64b6tfqq73lckadrhpihg2oubaxgqaoushquhcek46y3zumm.ipfs.localhost:8080 | |||
There was a problem hiding this comment.
I'd use dweb.link (see #7240). That way, this works for users without IPFS installed.
There was a problem hiding this comment.
@Stebalien Listings are still broken there (imposible to go into sublinks when on subdomain gateway), that is why I explicitly did not use it as an example.
We can switch to dweb.link when its actually uses 0.5 for subdomain feature.
There was a problem hiding this comment.
There was a problem hiding this comment.
Fix requires https://github.com/protocol/bifrost-infra/pull/573 to land
| @@ -246,15 +246,15 @@ Note: cURL doesn't follow redirects by default. To avoid breaking cURL and other | |||
|
|
|||
| The second feature is a face-lift to the directory listing theme and color palette. | |||
|
|
|||
| > http://bafybeia6po64b6tfqq73lckadrhpihg2oubaxgqaoushquhcek46y3zumm.ipfs.io/ | |||
| > http://bafybeia6po64b6tfqq73lckadrhpihg2oubaxgqaoushquhcek46y3zumm.ipfs.localhost:8080 | |||
lidel
commented
Apr 28, 2020
|
|
||
| #### IPNS | ||
|
|
||
| This release includes several new IPNS and IPNS-related features. | ||
|
|
||
| ##### ENS | ||
|
|
||
| IPFS now resolves [ENS](https://ens.domains/) names (e.g., [/ipns/ipfs.eth](https://ipfs.eth.dweb.link)) via DNSLink. | ||
| IPFS now resolves [ENS](https://ens.domains/) names (e.g., `/ipns/ipfs.eth`) via DNSLink provided by https://eth.link service. |
There was a problem hiding this comment.
ipfs.eth.dweb.link is invalid
https://ipfs.eth.ipfs.dweb.link wont have proper TLS setup, better to not link or link to a local gateway instead
Stebalien
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
(I already fixed this in https://github.com/ipfs/go-ipfs/releases/tag/v0.5.0)
cc @raulk @Stebalien