coreapi/unixfs: Use path instead of raw hash in AddEvent #5854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
4 tasks
magik6k
force-pushed
the
fix/coreapi/addeventpath
branch
from
ee7029f to
5dfdf33
Compare
Closed
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
magik6k
force-pushed
the
fix/coreapi/addeventpath
branch
from
5dfdf33 to
24e3176
Compare
Stebalien
approved these changes
Jan 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CoreAPI shouldn't have to touch string paths because we don't want it to have to deal with CID encoding. Related to #5789