refactor(cmds): use new cmds lib in version, tar and dns #5650
+75
−130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overbool
force-pushed
the
refactor/new-cmds-lib
branch
3 times, most recently
from
c3a840b to
c5f2099
Compare
overbool
changed the title
overbool
changed the title
|
@Stebalien I use new cmds lib in version, tar and dns command, could u help me review it? |
|
@overbool Could you point me to the issue with the original discussion that led to this patch? |
License: MIT Signed-off-by: Overbool <[email protected]>
License: MIT Signed-off-by: Overbool <[email protected]>
License: MIT Signed-off-by: Overbool <[email protected]>
overbool
force-pushed
the
refactor/new-cmds-lib
branch
from
6a208ca to
4160eaa
Compare
Stebalien
approved these changes
Oct 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License: MIT
Signed-off-by: Overbool [email protected]