object:refactor data encode error #5426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @schomatis, when i reading the ipfs repo,i have found some coding not very elegant.And i have do modify some code.Can you help me review this？ |
License: MIT Signed-off-by: Kejie Zhang <[email protected]>
magik6k
reviewed
Sep 5, 2018
core/commands/object/object.go
Outdated
| @@ -43,6 +40,12 @@ type Object struct { | |||
| Links []Link `json:"Links,omitempty"` | |||
| } | |||
|
|
|||
| var ( | |||
| // ErrObjectTooLarge is returned when too much data was read from stdin. current limit 2m | |||
| ErrObjectTooLarge = errors.New("input object was too large. limit is 2mbytes") | |||
There was a problem hiding this comment.
This isn't actually used, can probably just remove it
|
@magik6k remove it ,please help me review it.Thx |
magik6k
reviewed
Sep 5, 2018
core/commands/object/object.go
Outdated
| @@ -43,6 +40,10 @@ type Object struct { | |||
| Links []Link `json:"Links,omitempty"` | |||
| } | |||
|
|
|||
| var ( | |||
| ErrDataEncoding = errors.New("unkown data field encoding") | |||
kjzz
force-pushed
the
zkj/refactor
branch
2 times, most recently
from
dde8d9c to
7c08a22
Compare
License: MIT Signed-off-by: Kejie Zhang <[email protected]>
|
Hello @magik6k ,i have fmt code .But it still did not pass. can you help me look at this wrong ci.Maybe it has some wrong about ci. |
|
@magik6k thx for restarting ci.And the pr has passed required checks.Please help me review it.thank u a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License: MIT
Signed-off-by: Kejie Zhang [email protected]