wait for all connections to close before exiting on shutdown. #5322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Steven Allen <[email protected]>
Using httpServer.Shutdown will: 1. Close the listener (preventing new connections). 2. Close each connection as outstanding requests finish. This prevent us from shutting down before outstanding requests get a chance to respond. fixes #4055 License: MIT Signed-off-by: Steven Allen <[email protected]>
ghost
assigned 
magik6k
approved these changes
Jul 31, 2018
| "gx/ipfs/QmdE4gMduCKCGAcczM2F5ioYDfdeKuPix138wrES1YSr7f/go-ipfs-cmdkit" | ||
|
|
||
| cmds "github.com/ipfs/go-ipfs/commands" | ||
| ) | ||
|
|
||
| var daemonShutdownCmd = &cmds.Command{ | ||
| Helptext: cmdkit.HelpText{ | ||
| Tagline: "Shut down the ipfs daemon", |
There was a problem hiding this comment.
Maybe Schedule shutdown of the ipfs daemon?
There was a problem hiding this comment.
Well, it does shut it down. This will:
- Cancel in-progress requests.
- Wait for the IPFS node to close.
- Return.
Note: it won't actually wait for all in-progress requests to finish. That would deadlock.
Kubuxu
approved these changes
Aug 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using httpServer.Shutdown will:
Turns out this issue wasn't as tricky as I had thought.
This prevent us from shutting down before outstanding requests get a chance to respond.
fixes #4055