Fix missing profile docs #4846
Merged
Fix missing profile docs #4846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Kubuxu
reviewed
Mar 20, 2018
repo/config/profile.go
Outdated
| c.Addresses.NoAnnounce = appendSingle(c.Addresses.NoAnnounce, defaultServerFilters) | ||
| c.Swarm.AddrFilters = appendSingle(c.Swarm.AddrFilters, defaultServerFilters) | ||
| c.Discovery.MDNS.Enabled = false | ||
| return nil |
There was a problem hiding this comment.
Quick Q: shouldn't server profile also disable UPnP/NAT propagation?
victorb
reviewed
Mar 21, 2018
|
|
||
| If you apply this profile after ipfs init, you will need | ||
| to convert your datastore to the new configuration. | ||
| You can do this using ipfs-ds-convert. |
There was a problem hiding this comment.
Can we put a usage example of ipfs-ds-convert as well? Or maybe a link to the readme of ipfs-ds-convert is enough
victorb
reviewed
Mar 21, 2018
| Transform: func(c *Config) error { | ||
| c.Addresses.NoAnnounce = appendSingle(c.Addresses.NoAnnounce, defaultServerFilters) | ||
| c.Swarm.AddrFilters = appendSingle(c.Swarm.AddrFilters, defaultServerFilters) | ||
| c.Discovery.MDNS.Enabled = false |
There was a problem hiding this comment.
Why is MDNS disabled? Isn't the problem that we spam nearby ip addresses, not that we announce mdns services?
There was a problem hiding this comment.
IIRC Some providers don't like use of multicast addresses.
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
magik6k
force-pushed
the
feat/profile-help
branch
from
0520873 to
57d6a7c
Compare
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
magik6k
force-pushed
the
feat/profile-help
branch
from
e886e04 to
81e720c
Compare
Kubuxu
approved these changes
Mar 31, 2018
|
Thanks @magik6k :) |
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Feb 25, 2022
Fix missing profile docs
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Feb 25, 2022
Fix missing profile docs
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this pull request
Mar 4, 2022
Fix missing profile docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4843