Allow install.sh to be run without being the script dir #4547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Scott Bigelow <[email protected]>
magik6k
reviewed
Jan 5, 2018
cmd/ipfs/dist/install.sh
Outdated
| @@ -3,7 +3,9 @@ | |||
| # Installation script for ipfs. It tries to move $bin in one of the | |||
| # directories stored in $binpaths. | |||
|
|
|||
| bin=ipfs | |||
| INSTALL_DIR=`dirname $0` | |||
There was a problem hiding this comment.
Use $(..) syntax instead of backticks.
License: MIT Signed-off-by: Scott Bigelow <[email protected]>
magik6k
approved these changes
Jan 5, 2018
cmd/ipfs/dist/install.sh
Outdated
| bin=ipfs | ||
| INSTALL_DIR=$(dirname $0) | ||
|
|
||
| bin=$INSTALL_DIR/ipfs |
There was a problem hiding this comment.
sorry, one more comment. Put the value here in quotes:
bin="$INSTALL_DIR/ipfs"
Otherwise any spaces in the INSTALL_DIR path will break this
License: MIT Signed-off-by: Scott Bigelow <[email protected]>
|
Sure thing, definitely correct to quote. 2 line change, 2 bugs 😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very simple change, but took me a few minutes to resolve, since the documentation is specifically broken related to this.
https://ipfs.io/docs/install/#installing-from-a-prebuilt-package