"repo stat": Don't crash when Datastore.StorageMax is not defined

[kevina]

Closes #4241

License: MIT
Signed-off-by: Kevin Atkinson [email protected]

[kevina]

@whyrusleeping note I use math.MaxUint64 as the default value in the stat structure to avoid an API change and then simply don't report it in the repo stat command if the value is math.MaxUint64

[whyrusleeping]

@kevina I think '0' works as a default value too, might be a little easier to reason about

[kevina]

@whyrusleeping A very large value makes more logical sense. 0 could theoretically have a meaning as in no-storage. If the the of 0 is used for something bad things could happen. If a very large value is used, then it will effectively mean the same as no limit. That is why I think math.MaxUint64 makes more sence. If it was a floating point number I would use positive Infinity.

[kevina]

I can also make math.MaxUint64 a constant, say NoLimit, to make the code easier to read.

[Stebalien]

LGTM. 2EiB is probably enough storage for a single node :).