Return 404 Not Found for failed path resolutions #3777
Conversation
| return | ||
| } | ||
| fallthrough | ||
| default: | ||
| // all other erros | ||
| webError(w, "Path Resolve error", err, http.StatusBadRequest) | ||
| webError(w, "ipfs cat "+urlPath, err, http.StatusNotFound) |
There was a problem hiding this comment.
I think it should mention error here. HTTP codes are hidden in browser.
There was a problem hiding this comment.
The printed message contains err, so it's gonna be something like: "ipfs cat /ipns/foo.com: Could not resolve name"
ghost
mentioned this pull request
|
@lgierth So running |
|
Note: I'll amend this to return a different error "Code" in the response, instead of hijacking the http status code. |
License: MIT Signed-off-by: Lars Gierth <[email protected]>
ghost
force-pushed
the
fix/gateway-status-codes
branch
from
bf53b2a to
38504d1
Compare
License: MIT Signed-off-by: Lars Gierth <[email protected]>
ghost
force-pushed
the
fix/gateway-status-codes
branch
from
38504d1 to
807ffb9
Compare
done |
|
Checking why CI is upset |
|
Travis and Circle are happy now -- I didn't bother restarting the second Travis build though. |
|
Wait this isn't quite right |
|
Nevermind, I tested with the wrong binary. It does correctly return |
Return 404 Not Found for failed path resolutions This commit was moved from ipfs/kubo@2cc5ce4
Fixes #2286 -- bonus: also kills gateway's namesys dependency
But: I just noticed that the CLI assumes "command not found" for 404 responses. Great.