Limit number of objects in mdag batch to prevent too many fds issue #3756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubuxu
reviewed
Mar 7, 2017
merkledag/merkledag.go
Outdated
| // By default, only batch up to 256 nodes at a time. | ||
| // The current implementation of flatfs opens this many file | ||
| // descriptors at the same time for the optimized batch write. | ||
| MaxBlocks: 256, |
There was a problem hiding this comment.
I would reduce it even further. 256 blocks worst case scenario is 512 open fds (directory and file), and with almost 500 peers it is getting close to 1024 ulimit we set.
There was a problem hiding this comment.
mmm... fair enough. How about 200 even? I think we should rework how flatfs works/replace it soon.
…sues License: MIT Signed-off-by: Jeromy <[email protected]>
whyrusleeping
force-pushed
the
fix/limit-mdag-batch-objs
branch
from
0438646 to
31af335
Compare
|
should resolve #3752 |
Kubuxu
approved these changes
Mar 7, 2017
|
It doesn't fix everything, I am still getting this failure: It is slightly modified test as previously the error was being hidden by var capture. |
|
Ok, now it vanished. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain situations the 8MB size limit here would result in a large number of objects in the batch, which combined with peer connections, can easily hit the file descriptor limit.
License: MIT
Signed-off-by: Jeromy [email protected]