commands: fix opt.Description panic when desc was empty #3521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
:):) LGTM |
whyrusleeping
approved these changes
Dec 20, 2016
| @@ -43,6 +43,9 @@ func (o *option) Type() reflect.Kind { | |||
| } | |||
|
|
|||
| func (o *option) Description() string { | |||
| if len(o.description) == 0 { | |||
| return "" | |||
| } | |||
| if o.description[len(o.description)-1] != '.' { | |||
There was a problem hiding this comment.
We can change this to:
if !strings.HasSuffix(o.description, ".") {
o.description += "."
}License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
Kubuxu
force-pushed
the
feat/commands/no-option-desc
branch
from
00fac9a to
591e826
Compare
|
@whyrusleeping should be good for merge |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3520
License: MIT
Signed-off-by: Jakub Sztandera [email protected]