Feature/daemon mount offline flag #3022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -338,6 +339,11 @@ func daemonFunc(req cmds.Request, res cmds.Response) { | |||
| res.SetError(err, cmds.ErrNormal) | |||
| return | |||
| } | |||
| if mount && offline { | |||
| res.SetError(errors.New("mount is not supported in offline mode"), | |||
There was a problem hiding this comment.
not currently supported.
This is a usecase we do want, we just don't have time to have it in for the release
ipfs daemon --offline; ipfs mount; fails. This uniforms this behaviour. License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
whyrusleeping
force-pushed
the
feature/daemon-mount-offline-flag
branch
from
d26ac87 to
1ba42b6
Compare
|
rebased on master to rerun tests |
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
whyrusleeping
force-pushed
the
feature/daemon-mount-offline-flag
branch
from
1ba42b6 to
a423024
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.