From 7e6b198fba75a67f3bf40f9d29e2d361e09b25a2 Mon Sep 17 00:00:00 2001 From: Rod Vagg Date: Wed, 2 Feb 2022 16:50:53 +1100 Subject: [PATCH] fix: clarify comments re dag-cbor extension data As per dission in https://github.com/ipfs/go-graphsync/pull/338, we are going to be erroring on extension data that is not properly dag-cbor encoded from now on --- message/v1/message.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/message/v1/message.go b/message/v1/message.go index d6cb4515..969d7784 100644 --- a/message/v1/message.go +++ b/message/v1/message.go @@ -245,7 +245,8 @@ func (mh *MessageHandler) newMessageFromProto(p peer.ID, pbm *pb.Message) (messa return message.NewMessage(requests, responses, blks), nil } -// TODO: is this a breaking protocol change? force all extension data into dag-cbor? +// Note that even for protocol v1 we now only support DAG-CBOR encoded extension data. +// Anything else will be rejected with an error. func toEncodedExtensions(part MessagePartWithExtensions) (map[string][]byte, error) { names := part.ExtensionNames() out := make(map[string][]byte, len(names)) @@ -264,7 +265,6 @@ func toEncodedExtensions(part MessagePartWithExtensions) (map[string][]byte, err return out, nil } -// TODO: is this a breaking protocol change? force all extension data into dag-cbor? func fromEncodedExtensions(in map[string][]byte) ([]graphsync.ExtensionData, error) { if in == nil { return []graphsync.ExtensionData{}, nil