Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Add Wasm examples to GitHub Actions #343

Closed
4 of 7 tasks
cycraig opened this issue Jul 30, 2021 · 0 comments · Fixed by #345
Closed
4 of 7 tasks

[Task] Add Wasm examples to GitHub Actions #343

cycraig opened this issue Jul 30, 2021 · 0 comments · Fixed by #345
Assignees
Labels
Chore Tedious, typically non-functional change Wasm Related to Wasm bindings. Becomes part of the Wasm changelog

Comments

@cycraig
Copy link
Contributor

cycraig commented Jul 30, 2021

Description

Add runnable examples to the GitHub Actions CI pipeline.

Motivation

While the Rust examples are strongly-typed and compiled in the build-and-test pipeline, giving us assurance that they at least compile and therefore likely run, the Wasm browser and node examples are not parsed at all. This leads to silent breakages when any exported symbols change that can go unnoticed for some time.

A periodic task similar to the audit task might be appropriate as the examples can sometimes fail intermittently and take a long time to execute. Adding them to the build-and-test task would detect breakages more quickly and identify the exact set of changes responsible, but likely result in more false-positives along with slowing down the CI overall.

Maybe add the Wasm README.md examples (#342) to the same task once they are runnable?

Resources

To-do list

Change checklist

  • The feature or fix is implemented in Rust and across all bindings whereas possible.
  • The feature or fix has sufficient testing coverage
  • All tests and examples build and run locally as expected
  • Every piece of code has been document according to the documentation guidelines.
  • If conceptual documentation (mdbook) and examples highlighting the feature exist, they are properly updated.
  • If the feature is not currently documented, a documentation task Issue has been opened to address this.
@cycraig cycraig added Binding Wasm Related to Wasm bindings. Becomes part of the Wasm changelog labels Jul 30, 2021
@cycraig cycraig mentioned this issue Aug 2, 2021
10 tasks
@cycraig cycraig linked a pull request Aug 2, 2021 that will close this issue
10 tasks
@cycraig cycraig self-assigned this Aug 4, 2021
@cycraig cycraig added the Chore Tedious, typically non-functional change label Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore Tedious, typically non-functional change Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant