fix(docs): escape backticks in type or default value columns #6025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, looks like some tests are failing. Let me fix those up, running the whole suite was tanking my laptop. |
brandongregoryscott
force-pushed
the
fix/escape-backticks
branch
from
8e53f21 to
23f3cbd
Compare
|
This was released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
fixes #6024
What is the new behavior?
Types or default values that include a backtick are escaped with two backticks and a space.
Documentation
Does this introduce a breaking change?
Testing
See the new unit tests in
markdown-props.spec.ts. If you think the logic for this bug fix should exist somewhere else, let me know!Other information