Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mock-doc): add pathname to mock anchors #3090

Merged
merged 4 commits into from
Oct 11, 2021

Conversation

tricki
Copy link
Contributor

@tricki tricki commented Oct 2, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Unit tests (npm test) were run locally and passed
  • E2E Tests (npm run test.karma.prod) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

MockAnchorElements don't have a pathname property.

GitHub Issue Number: #2969

What is the new behavior?

The pathname is generated based on the href and returned.

Does this introduce a breaking change?

  • Yes
  • No

Testing

I wasn't able to run the E2E tests because it couldn't connect to Edge.

Other information

@tricki tricki requested a review from a team October 2, 2021 11:11
Copy link
Contributor

@rwaskiewicz rwaskiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I had two minor nitpicks, otherwise this looks good to me

CI is failing right now - unfortunately that's a flaky e2e test. No action required on your part there

@rwaskiewicz rwaskiewicz added the Awaiting Reply This PR or Issue needs a reply from the original reporter. label Oct 4, 2021
@rwaskiewicz
Copy link
Contributor

Thanks!

@ionitron-bot ionitron-bot bot added Reply Received and removed Awaiting Reply This PR or Issue needs a reply from the original reporter. labels Oct 11, 2021
@rwaskiewicz rwaskiewicz merged commit 99428c7 into stenciljs:main Oct 11, 2021
@rwaskiewicz rwaskiewicz added the Resolution: Refine This PR is marked for Jira refinement. We're not working on it - we're talking it through. label Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Refine This PR is marked for Jira refinement. We're not working on it - we're talking it through.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants