chore(config): migrate additional callsites to ValidatedConfig (#3498)

this commit propagates the usage of `ValidatedConfig` throughout
various parts of the code. the changes are distributed and small in size,
which made it feel unnecessary to split into multiple pull requests, given
the nature of the changes being proposed.

this is being done following making sys a required field on ValidatedConfig
in 991843a (#3491), where driving down the number of sys-related violations of
the compile time check is the primary driver.

src/cli/task-generate.ts

@@ -1,4 +1,4 @@
-import type { Config, ValidatedConfig } from '../declarations';
+import type { ValidatedConfig } from '../declarations';
 import type { CoreCompiler } from './load-compiler';
 import { IS_NODE_ENV } from '../compiler/sys/environment';
 import { validateComponentTag } from '@utils';
@@ -139,7 +139,7 @@ const getFilepathForFile = (
  * used to print out a little summary of our activity to the user.
  */
 const getBoilerplateAndWriteFile = async (
-  config: Config,
+  config: ValidatedConfig,
   componentName: string,
   withCss: boolean,
   file: BoilerplateFile
@@ -161,7 +161,7 @@ const getBoilerplateAndWriteFile = async (
  * @param files  the files we want to check
  * @param config the Config object, used here to get access to `sys.readFile`
  */
-const checkForOverwrite = async (files: readonly BoilerplateFile[], config: Config): Promise<void> => {
+const checkForOverwrite = async (files: readonly BoilerplateFile[], config: ValidatedConfig): Promise<void> => {
   const alreadyPresent: string[] = [];
 
   await Promise.all(

src/cli/test/run.spec.ts

@@ -112,8 +112,8 @@ describe('run', () => {
 
   describe('runTask()', () => {
     let sys: d.CompilerSystem;
-    let unvalidatedConfig: d.Config;
-    let validatedConfig: d.Config;
+    let unvalidatedConfig: d.UnvalidatedConfig;
+    let validatedConfig: d.ValidatedConfig;
 
     let taskBuildSpy: jest.SpyInstance<ReturnType<typeof BuildTask.taskBuild>, Parameters<typeof BuildTask.taskBuild>>;
     let taskDocsSpy: jest.SpyInstance<ReturnType<typeof DocsTask.taskDocs>, Parameters<typeof DocsTask.taskDocs>>;

src/compiler/sys/worker/sys-worker.ts

@@ -1,9 +1,9 @@
-import type { Config } from '../../../declarations';
+import type { ValidatedConfig } from '../../../declarations';
 import { createWorkerContext } from '../../worker/worker-thread';
 import { createWorkerMainContext } from '../../worker/main-thread';
 import { isFunction } from '@utils';
 
-export const createSysWorker = (config: Config) => {
+export const createSysWorker = (config: ValidatedConfig) => {
   if (
     isFunction(config.sys.createWorkerController) &&
     config.maxConcurrentWorkers > 0 &&

src/compiler/transpile/create-build-program.ts

@@ -10,7 +10,7 @@ import ts from 'typescript';
  * @returns a Program that marries the TypeScript and Stencil compilers together.
  */
 export const createTsBuildProgram = async (
-  config: d.Config,
+  config: d.ValidatedConfig,
   buildCallback: (tsBuilder: ts.BuilderProgram) => Promise<void>
 ): Promise<ts.WatchOfConfigFile<ts.EmitAndSemanticDiagnosticsBuilderProgram>> => {
   let isBuildRunning = false;

src/compiler/transpile/create-watch-program.ts

@@ -3,7 +3,7 @@ import { getTsOptionsToExtend } from './ts-config';
 import ts from 'typescript';
 
 export const createTsWatchProgram = async (
-  config: d.Config,
+  config: d.ValidatedConfig,
   buildCallback: (tsBuilder: ts.BuilderProgram) => Promise<void>
 ) => {
   let isRunning = false;

src/compiler/transpile/ts-config.ts

@@ -2,7 +2,7 @@ import type * as d from '../../declarations';
 import { isOutputTargetDistTypes } from '../output-targets/output-utils';
 import ts from 'typescript';
 
-export const getTsOptionsToExtend = (config: d.Config) => {
+export const getTsOptionsToExtend = (config: d.ValidatedConfig) => {
   const tsOptions: ts.CompilerOptions = {
     experimentalDecorators: true,
     declaration: config.outputTargets.some(isOutputTargetDistTypes),

src/compiler/types/stencil-types.ts

@@ -112,7 +112,7 @@ const updateTypeName = (currentTypeName: string, typeAlias: d.TypesMemberNameDat
  * @returns the results of writing one or more type declaration files to disk
  */
 export const copyStencilCoreDts = async (
-  config: d.Config,
+  config: d.ValidatedConfig,
   compilerCtx: d.CompilerCtx
 ): Promise<ReadonlyArray<d.FsWriteResults>> => {
   const typesOutputTargets = config.outputTargets.filter(isOutputTargetDistTypes).filter((o) => o.typesDir);