Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: When side menu is disabled, expose-aside-when="large" still triggers #2210

Closed
matiastucci opened this issue Sep 15, 2014 · 13 comments
Closed

Comments

@matiastucci
Copy link

Type: bug

Platform: all

In the 'ion-side-menu' when is-enabled="false", expose-aside-when="large" is still triggering. So in some sections I am disabling the menu but if the width is greater than 768px the menu is still appearing.

Codepen: http://codepen.io/matiastucci/pen/oHapg

@matiastucci matiastucci changed the title bug: When is-enabled="false" aside menu still triggers bug: When side menu is disabled, expose-aside-when="large" still triggers Sep 15, 2014
@adamdbradley
Copy link
Contributor

Thanks for the codepen example!

@matiastucci
Copy link
Author

Perfect, thanks to you!

@matiastucci
Copy link
Author

In the nightly this should be fixed?

@matiastucci
Copy link
Author

Sorry to reopen this, but is still happening: http://codepen.io/matiastucci/pen/JeAsl?editors=100

Thanks!

@zarko-tg
Copy link

.@matiastucci i can confirm the same.

@gsohn
Copy link

gsohn commented Dec 20, 2014

Same here

@flinn
Copy link

flinn commented Mar 10, 2015

The expose-aside-when feature is pretty poorly thought out/configured IMO... There needs to be an easier way to override when to show/hide the exposed side menu, beyond using media queries -- We need to be able to control this easily with JS as well! I think the directive needs another attribute that takes a true/false expression and shows or hides itself based upon that.

As an example: If a user hasn't logged into my app yet, I may not want to have the side menu options exposed (they might be dynamically set according to the user). In this case, having expose-aside-when set to large will unfortunately ensure that the side menu is always shown which means I can't use it without writing my own code for fighting against the way it currently works.

@ni0ki
Copy link

ni0ki commented Mar 24, 2015

I'm also having the problem. I didn't found a proper way to close / toggle a left side menu which has the expose-aside-when directive. Using $ionicSideMenuDelegate.isOpenLeft() always returns false. This is quite inconsistent. Even when using directives such as ng-if or ng-show, I didn't manage to find a solution !

Thanks

@Fayozjon
Copy link

noKid

http://pain-advice.com/betonmarkets-front

24.03.2015, 14:12, "noKid" [email protected]:I'm also having the problem. I didn't found a proper way to close / toggle a side menu which have the expose-aside-when directive. Using $ionicSideMenuDelegate.isOpenLeft() always returns false. This is inconsistent and should be changed.

Thanks

—Reply to this email directly or .

@unek
Copy link

unek commented Jun 6, 2015

it's still visible even though disabled

@5im0n
Copy link
Contributor

5im0n commented Sep 16, 2015

Tis bug is still present in the v1.1.0

@lordgreg
Copy link

lordgreg commented Nov 3, 2015

I also have this bug when using expose-aside-when and it's really annoying. Did someone found a workaround for this?

Here's a simple "hack" I've made that could maybe help others:

  1. create ng-class for <ion-side-menu-content> with a statement:
<ion-side-menu-content ng-class="{'menu-disabled': state.current.name === 'app.login'>
  1. Add css element menu-disabled in your CSS file:
ion-side-menu-content.menu-disabled {
  width: auto !important;
  transform: initial !important;
}
  1. ???
  2. Profit.

👍

@bianchimro
Copy link

hi,
in version 1.3 I am still getting the same behavior (exposed-aside-when seems to override is-enabled)

@lordgreg approach solves my use case, but this is still a bug / inconsistency in my opinion.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests