-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(progress-bar): add Progress Bar #16559
Conversation
I like it a lot! we could definitely merge it after 4.0 final is released! We try to avoid nested SCSS rules, could you try to flatten that to at most 1 level nested? |
Very nice! I'll review this soon. |
Co-Authored-By: paulstelzer <[email protected]>
This is looking really good! I added some comments for places the docs could improve but it isn't critical. 🙂 My only concern with the API is using |
@brandyscarney I like While type is a property of button and input, it's not a global HTML attribute. |
@brandyscarney Thanks for your review! What about the css variables? @manucorporat and I discussed a lot of it yesterday, at the end, this is my favorite (it's not in this PR already):
|
@paulstelzer @brandyscarney I would:
--color: #{ion-color(primary, base)};
--background: #{ion-color(primary, base, 0.2)};
--progress-bar-background: var(--color);
--buffer-bar-background: var(--background); |
I think we should keep it simple like the following:
which would allow for things like this to come in later:
Also, avoid using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM!!!
Co-Authored-By: paulstelzer <[email protected]>
Co-Authored-By: paulstelzer <[email protected]>
Co-Authored-By: paulstelzer <[email protected]>
Short description of what this resolves:
Adds a progress bar component to Ionic 4. Animation is based on MD spec (https://material.io/design/components/progress-indicators.html#linear-progress-indicators )
Feature Request: #16558
BASIC
Preview