Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(angular): default value of BooleanValueAccessor should be false #16420

Merged
merged 2 commits into from
Nov 22, 2018
Merged

fix(angular): default value of BooleanValueAccessor should be false #16420

merged 2 commits into from
Nov 22, 2018

Conversation

MarkChrisLevy
Copy link
Contributor

Short description of what this resolves:

Default value should be false, not empty string. If empty string was given and checkbox was part of angular form, it was checked by default.

@ionitron-bot ionitron-bot bot added the package: angular @ionic/angular package label Nov 21, 2018
@manucorporat manucorporat merged commit 429e083 into ionic-team:master Nov 22, 2018
@MarkChrisLevy MarkChrisLevy deleted the fix-angular-boolean-value-accessor branch December 19, 2018 08:48
@MarkChrisLevy MarkChrisLevy restored the fix-angular-boolean-value-accessor branch December 19, 2018 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: angular @ionic/angular package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkChrisLevy @manucorporat