fix(segment): adds global variables for targeting segment in toolbar #16344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandyscarney
changed the title
brandyscarney
added a commit
to ionic-team/ionic-docs
that referenced
this pull request
Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Currently the segment does not use the available toolbar color variables:
I could have made it use these but then we run into the problem of not being able to customize only the segment buttons (separate from the text or buttons) when they're unchecked or checked. For example, in order to recreate the following:
We would need to be able to pass an opacity to the unchecked color. Without the user specifying the opacity or passing an rgb, we can't manipulate only the single color. So basically we needed to add another variable in order to keep the buttons in a toolbar one color
#ffffffand the unchecked segment buttons another colorrgba(255, 255, 255, .6). Thus I have added the following CSS globals to customize segment further:Granted
--ion-toolbar-color-checkedcould be left out, and we could just use the value of--ion-toolbar-color, but since our defaults set checked to the primary color I figure we should offer full control.