fix(angular forms): make sure angular form control onChange is fired when needed #16126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Whether onChange should be mutted (not be fired). Will be true only when writeValue was called, which | ||
| * means that value changed inside angular form (e.g. calling setValue on a control). | ||
| */ | ||
| private muteOnChange: boolean; |
There was a problem hiding this comment.
I would give it a value by default
Suggested change
| private muteOnChange: boolean; | |
| private muteOnChange = false; |
There was a problem hiding this comment.
There was a problem hiding this comment.
Sorry i meant this change for all the accessors
There was a problem hiding this comment.
Ups, my fault. Done!
…cessor.ts Co-Authored-By: mmlleevvyy <[email protected]>
|
Thanks a lot for the PR!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Fixes #16125
Changes proposed in this pull request:
Ionic Version: 1.x / 2.x / 3.x / 4.x
Fixes: #