Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ionic 4] Fab Button is missing "direction" #15551

Closed
vandres opened this issue Sep 11, 2018 · 3 comments
Closed

[Ionic 4] Fab Button is missing "direction" #15551

vandres opened this issue Sep 11, 2018 · 3 comments
Assignees

Comments

@vandres
Copy link

vandres commented Sep 11, 2018

Bug Report

Ionic Info
Run ionic info from a terminal/cmd prompt and paste the output below.

Ionic:

   ionic (Ionic CLI)          : 4.1.2 (/usr/local/lib/node_modules/ionic)
   Ionic Framework            : @ionic/angular 4.0.0-beta.7
   @angular-devkit/core       : 0.7.5
   @angular-devkit/schematics : 0.7.5
   @angular/cli               : 6.1.5
   @ionic/ng-toolkit          : 1.0.8
   @ionic/schematics-angular  : 1.0.6

System:

   NodeJS : v9.11.1 (/usr/local/bin/node)
   npm    : 6.4.1
   OS     : macOS High Sierra

Describe the Bug
I would like to use an ion-fab-button with a href as I would use an ion-button. But the attribute "direction" is missing.

Related Code

<!-- direction exists -->
<ion-button expand="full" href="/login" direction="forward">Login</ion-button>

<!-- direction does not exist -->
<ion-fab vertical="bottom" horizontal="center" edge slot="fixed">
        <ion-fab-button href="/plant-add" direction="forward">
            <ion-icon name="add"></ion-icon>
        </ion-fab-button>
    </ion-fab>
@ionitron-bot ionitron-bot bot added the triage label Sep 11, 2018
@aam-antonio
Copy link

You can use routerLink with routerDirection:

<ion-fab vertical="bottom" horizontal="center" edge slot="fixed">
    <ion-fab-button routerLink="/plant-add" routerDirection="forward">
        <ion-icon name="add"></ion-icon>
    </ion-fab-button>
</ion-fab>

@vandres
Copy link
Author

vandres commented Sep 11, 2018

@aam-antonio Thank you, this works. But why not use this for ion-button then too. Why the inconsistency?

@manucorporat manucorporat self-assigned this Sep 11, 2018
@ionitron-bot ionitron-bot bot removed the triage label Sep 11, 2018
@ionitron-bot
Copy link

ionitron-bot bot commented Oct 12, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Oct 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants