Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0.0-beta.5] NavController.navigate* inconsistent signatures #15353

Closed
ptitjes opened this issue Aug 28, 2018 · 1 comment
Closed

[4.0.0-beta.5] NavController.navigate* inconsistent signatures #15353

ptitjes opened this issue Aug 28, 2018 · 1 comment
Assignees

Comments

@ptitjes
Copy link
Contributor

ptitjes commented Aug 28, 2018

Bug Report

Ionic Info

Ionic:

   ionic (Ionic CLI)          : 4.0.6 (/opt/npm/lib/node_modules/ionic)
   Ionic Framework            : @ionic/angular 4.0.0-beta.5
   @angular-devkit/core       : 0.7.5
   @angular-devkit/schematics : 0.7.5
   @angular/cli               : 6.1.5
   @ionic/ng-toolkit          : 1.0.7
   @ionic/schematics-angular  : 1.0.5

Capacitor:

   capacitor (Capacitor CLI) : 1.0.0-beta.7
   @capacitor/core           : 1.0.0-beta.7

System:

   NodeJS : v8.9.1 (/usr/local/bin/node)
   npm    : 6.4.0
   OS     : Linux 4.17

Describe the Bug
In 7aa4f13, | any[] was added to the signature of the first parameter of navigateForward(). It was forgotten on the methods navigateBack() and navigateRoot().

Additional Context
This commit was supposed to fix #15332.

The incriminated commit is 7aa4f13#diff-68c0efda98168f58059a80de770871e5L24

@ionitron-bot ionitron-bot bot added the triage label Aug 28, 2018
@ptitjes ptitjes changed the title Ionic 4.0.0-beta.5: NavController.navigate* inconsistent signatures [4.0.0-beta.5] NavController.navigate* inconsistent signatures Aug 28, 2018
@manucorporat manucorporat self-assigned this Aug 28, 2018
@ionitron-bot ionitron-bot bot removed the triage label Aug 28, 2018
@ionitron-bot
Copy link

ionitron-bot bot commented Sep 27, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants