Skip to content

Commit

Permalink
feat(all): custom icons
Browse files Browse the repository at this point in the history
  • Loading branch information
manucorporat committed May 17, 2018
1 parent fc078af commit e6638e7
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions core/src/components/action-sheet/action-sheet.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ export class ActionSheet implements OverlayInterface {
<button class={buttonClass(b)} onClick={() => this.buttonClick(b)}>
<span class="action-sheet-button-inner">
{b.icon
? <ion-icon name={b.icon} class="action-sheet-icon" />
? <ion-icon icon={b.icon} class="action-sheet-icon" />
: null}
{b.text}
</span>
Expand All @@ -258,7 +258,7 @@ export class ActionSheet implements OverlayInterface {
<span class="action-sheet-button-inner">
{cancelButton.icon
? <ion-icon
name={cancelButton.icon}
icon={cancelButton.icon}
class="action-sheet-icon"
/>
: null}
Expand Down
2 changes: 1 addition & 1 deletion core/src/components/back-button/back-button.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export class BackButton {
class={backButtonClasses}
onClick={(ev) => this.onClick(ev)}>
<span class="back-button-inner">
{ backButtonIcon && <ion-icon name={backButtonIcon}/> }
{ backButtonIcon && <ion-icon icon={backButtonIcon}/> }
{ this.mode === 'ios' && backButtonText && <span class="button-text">{backButtonText}</span> }
{ this.mode === 'md' && <ion-ripple-effect tapClick={true}/> }
</span>
Expand Down
2 changes: 1 addition & 1 deletion core/src/components/menu-button/menu-button.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export class MenuButton {
<ion-menu-toggle menu={this.menu} autoHide={this.autoHide}>
<ion-button>
<slot>
<ion-icon slot="icon-only" name={menuIcon}/>
<ion-icon icon={menuIcon} slot="icon-only" />
</slot>
</ion-button>
</ion-menu-toggle>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export class RefresherContent {
<div class="refresher-pulling">
{this.pullingIcon &&
<div class="refresher-pulling-icon">
<ion-icon name={this.pullingIcon}></ion-icon>
<ion-icon icon={this.pullingIcon}></ion-icon>
</div>
}
{this.pullingText &&
Expand Down
2 changes: 1 addition & 1 deletion core/src/components/tab-button/tab-button.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export class TabButton {
class="tab-cover"
onKeyUp={this.onKeyUp.bind(this)}
onBlur={this.onBlur.bind(this)}>
{ tab.icon && <ion-icon class="tab-button-icon" name={tab.icon}></ion-icon> }
{ tab.icon && <ion-icon class="tab-button-icon" icon={tab.icon}></ion-icon> }
{ tab.label && <span class="tab-button-text">{tab.label}</span> }
{ tab.badge && <ion-badge class="tab-badge" color={tab.badgeColor}>{tab.badge}</ion-badge> }
{ this.mode === 'md' && <ion-ripple-effect tapClick={true}/> }
Expand Down

0 comments on commit e6638e7

Please sign in to comment.